From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] [libstdc++] xfail noreplace tests on vxworks
Date: Fri, 17 Feb 2023 11:00:54 +0000 [thread overview]
Message-ID: <CAH6eHdQmz3KW_PsHziFiF9XE=nT0fpbBwhA61A+ZDXoViCWn4A@mail.gmail.com> (raw)
In-Reply-To: <orttzkrb8u.fsf@lxoliva.fsfla.org>
[-- Attachment #1: Type: text/plain, Size: 2091 bytes --]
On Fri, 17 Feb 2023, 07:40 Alexandre Oliva via Libstdc++, <
libstdc++@gcc.gnu.org> wrote:
>
> vxworks ignores O_EXCL in open, so noreplace open succeeds when it is
> expected to fail. xfail the tests.
>
> Regstrapped on x86_64-linux-gnu.
> Tested on arm-vxworks7 (gcc-12) and arm-eabi (trunk). Ok to install?
>
OK, thanks.
(We need a similar change for hp-ux and Solaris, at least. Which means we
need to change the impl to not assume it works.)
> for libstdc++-v3/ChangeLog
>
> * testsuite/27_io/basic_ofstream/open/char/noreplace.cc: xfail
> on vxworks.
> * testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc:
> Likewise.
> ---
> .../27_io/basic_ofstream/open/char/noreplace.cc | 2 +-
> .../27_io/basic_ofstream/open/wchar_t/noreplace.cc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc
> b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc
> index 56ff2d7cead3c..2e99707df86d0 100644
> --- a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc
> +++ b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc
> @@ -1,4 +1,4 @@
> -// { dg-do run }
> +// { dg-do run { xfail *-*-vxworks* } }
>
> #include <ios>
>
> diff --git
> a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc
> b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc
> index f0425cdab3d23..ddb7fd691608c 100644
> --- a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc
> +++ b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc
> @@ -1,4 +1,4 @@
> -// { dg-do run }
> +// { dg-do run { xfail *-*-vxworks* } }
>
> #include <version>
>
>
> --
> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
> Free Software Activist GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts. Ask me about <https://stallmansupport.org>
>
prev parent reply other threads:[~2023-02-17 11:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 7:40 Alexandre Oliva
2023-02-17 11:00 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH6eHdQmz3KW_PsHziFiF9XE=nT0fpbBwhA61A+ZDXoViCWn4A@mail.gmail.com' \
--to=jwakely.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=oliva@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).