From: Costas Argyris <costas.argyris@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] driver: Treat include path args the same way between cpp_unique_options and asm_options. [PR71850]
Date: Mon, 27 Mar 2023 10:36:55 +0100 [thread overview]
Message-ID: <CAHyHGCkUHj3k=aV_PB5sbvGvFU7jpRpWS8pgTLJ4D6X1Gz=3Vw@mail.gmail.com> (raw)
In-Reply-To: <CAHyHGCmfe-amEX-2+WhDkL21m0ObFqU=L4okgPNSM3GkPuVEZg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]
[ping^3]
This looks like it fixes the bug and also unifies the way include paths are
passed from the driver to the compiler and assembler (when a @file has
been passed to the driver in the first place).
That is, when @file has been passed to the driver, put the include paths
in a temp @file and pass them to the assembler. Note this is already
happening for the compiler, so this patch merely extends this logic to the
assembler.
Is there any reason not to go for it?
On Mon, 20 Mar 2023 at 09:47, Costas Argyris <costas.argyris@gmail.com>
wrote:
> ping
>
> On Thu, 9 Mar 2023 at 13:39, Costas Argyris <costas.argyris@gmail.com>
> wrote:
>
>> Pinging list and driver reviewer.
>>
>> Details here:
>>
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71850
>>
>> On Thu, 2 Mar 2023 at 19:25, Costas Argyris <costas.argyris@gmail.com>
>> wrote:
>>
>>> This is a proposal to fix PR71850 by applying the existing logic for
>>> passing include paths to cc1 to as.
>>>
>>> Thanks,
>>> Costas
>>>
>>
next prev parent reply other threads:[~2023-03-27 9:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 19:25 Costas Argyris
2023-03-09 13:39 ` Costas Argyris
2023-03-20 9:47 ` Costas Argyris
2023-03-27 9:36 ` Costas Argyris [this message]
2023-03-27 9:59 ` Xi Ruoyao
2023-03-27 10:11 ` Costas Argyris
2023-04-17 8:29 ` Costas Argyris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHyHGCkUHj3k=aV_PB5sbvGvFU7jpRpWS8pgTLJ4D6X1Gz=3Vw@mail.gmail.com' \
--to=costas.argyris@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).