public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ramana Radhakrishnan <ramana.gcc@googlemail.com>
To: Lance Fredrickson <lancethepants@gmail.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
	Richard Earnshaw <rearnsha@arm.com>
Subject: Re: [PATCH V2] arm: add -static-pie support
Date: Wed, 10 Aug 2022 21:30:59 +0100	[thread overview]
Message-ID: <CAJA7tRZ+hviLM843UK3e0fhEW+YgdbncYhGmmEFK9Lm5deGSGA@mail.gmail.com> (raw)
In-Reply-To: <0edd0061-3b4e-7e9b-c2b5-517126252ffa@gmail.com>

Hi Lance,

Thanks for your contribution - looks like your first one to GCC ?

The patch looks good to me, though it should probably go through a
full test suite run on arm-linux-gnueabihf and get a ChangeLog - see
here for more https://gcc.gnu.org/contribute.html#patches.

This is probably small enough to go under the 10 line rule but since
you've used Signed-off-by in your patch, is that indicating you are
contributing under DCO rules -
https://gcc.gnu.org/contribute.html#legal ?

regards
Ramana


On Thu, Aug 4, 2022 at 5:48 PM Lance Fredrickson via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Just a follow up trying to get some eyes on my static-pie patch
> submission for arm.
> Feedback welcome.
> https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598610.html
>
> thanks,
> Lance Fredrickson

  reply	other threads:[~2022-08-10 20:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 14:06 Lance Fredrickson
2022-08-04 16:47 ` Lance Fredrickson
2022-08-10 20:30   ` Ramana Radhakrishnan [this message]
2022-08-16  3:05     ` Lance Fredrickson
2022-09-05 13:13       ` Andrea Corallo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJA7tRZ+hviLM843UK3e0fhEW+YgdbncYhGmmEFK9Lm5deGSGA@mail.gmail.com \
    --to=ramana.gcc@googlemail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=lancethepants@gmail.com \
    --cc=rearnsha@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).