* [PATCH][ARM]Add ACLE 2.0 predefined marco __ARM_FEATURE_IDIV
@ 2014-10-13 14:19 Renlin Li
2014-10-21 14:46 ` Ramana Radhakrishnan
0 siblings, 1 reply; 6+ messages in thread
From: Renlin Li @ 2014-10-13 14:19 UTC (permalink / raw)
To: gcc-patches; +Cc: ramana Radhakrishnan, richard Earnshaw
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
Hi all,
This is a simple patch to add missing __ARM_FEATURE_IDIV__ predefined marco(ACLE 2.0) into TARGET_CPU_CPP_BUILTINS.
Is it Okay to commit?
gcc/ChangeLog:
2014-10-13 Renlin Li <Renlin.Li@arm.com>
* config/arm/arm.h (TARGET_CPU_CPP_BUILTINS): Add ACLE 2.0 predefined
marco __ARM_FEATURE_IDIV__.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: arm_idiv.patch --]
[-- Type: text/x-patch; name=arm_idiv.patch, Size: 569 bytes --]
diff --git a/gcc/config/arm/arm.h b/gcc/config/arm/arm.h
index 3623c70..941d1b4 100644
--- a/gcc/config/arm/arm.h
+++ b/gcc/config/arm/arm.h
@@ -164,7 +164,10 @@ extern char arm_arch_name[];
builtin_define ("__ARM_EABI__"); \
} \
if (TARGET_IDIV) \
- builtin_define ("__ARM_ARCH_EXT_IDIV__"); \
+ { \
+ builtin_define ("__ARM_ARCH_EXT_IDIV__"); \
+ builtin_define ("__ARM_FEATURE_IDIV__"); \
+ }
} while (0)
#include "config/arm/arm-opts.h"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][ARM]Add ACLE 2.0 predefined marco __ARM_FEATURE_IDIV
2014-10-13 14:19 [PATCH][ARM]Add ACLE 2.0 predefined marco __ARM_FEATURE_IDIV Renlin Li
@ 2014-10-21 14:46 ` Ramana Radhakrishnan
2014-10-22 10:13 ` [COMMITTED][PATCH][ARM]Add " Jiong Wang
0 siblings, 1 reply; 6+ messages in thread
From: Ramana Radhakrishnan @ 2014-10-21 14:46 UTC (permalink / raw)
To: Renlin Li; +Cc: gcc-patches, ramana Radhakrishnan, richard Earnshaw
On Mon, Oct 13, 2014 at 3:15 PM, Renlin Li <renlin.li@arm.com> wrote:
> Hi all,
>
> This is a simple patch to add missing __ARM_FEATURE_IDIV__ predefined
> marco(ACLE 2.0) into TARGET_CPU_CPP_BUILTINS.
> Is it Okay to commit?
>
>
> gcc/ChangeLog:
>
> 2014-10-13 Renlin Li <Renlin.Li@arm.com>
>
> * config/arm/arm.h (TARGET_CPU_CPP_BUILTINS): Add ACLE 2.0 predefined
> marco __ARM_FEATURE_IDIV__.
Replace this with "Define __ARM_FEATURE_IDIV__." in the Changelog.
Ok with that change.
Ramana
^ permalink raw reply [flat|nested] 6+ messages in thread
* [COMMITTED][PATCH][ARM]Add ACLE 2.0 predefined marco __ARM_FEATURE_IDIV
2014-10-21 14:46 ` Ramana Radhakrishnan
@ 2014-10-22 10:13 ` Jiong Wang
2014-10-23 10:09 ` Ramana Radhakrishnan
0 siblings, 1 reply; 6+ messages in thread
From: Jiong Wang @ 2014-10-22 10:13 UTC (permalink / raw)
To: Ramana Radhakrishnan; +Cc: Renlin Li, gcc-patches
On 21/10/14 15:30, Ramana Radhakrishnan wrote:
> On Mon, Oct 13, 2014 at 3:15 PM, Renlin Li <renlin.li@arm.com> wrote:
>> Hi all,
>>
>> This is a simple patch to add missing __ARM_FEATURE_IDIV__ predefined
>> marco(ACLE 2.0) into TARGET_CPU_CPP_BUILTINS.
>> Is it Okay to commit?
>>
>>
>> gcc/ChangeLog:
>>
>> 2014-10-13 Renlin Li <Renlin.Li@arm.com>
>>
>> * config/arm/arm.h (TARGET_CPU_CPP_BUILTINS): Add ACLE 2.0 predefined
>> marco __ARM_FEATURE_IDIV__.
> Replace this with "Define __ARM_FEATURE_IDIV__." in the Changelog.
>
> Ok with that change.
committed on behalf of Renlin as 216547.
2014-10-22 Renlin Li <renlin.li@arm.com>
gcc/
* config/arm/arm.h (TARGET_CPU_CPP_BUILTINS): Define
__ARM_FEATURE_IDIV__.
Also fixed the missing '\' on the last line as obvious
2014-10-22 Jiong Wang <jiong.wang@arm.com>
gcc/
* config/arm/arm.h (TARGET_CPU_CPP_BUILTINS): Add missing '\'.
Index: gcc/config/arm/arm.h
===================================================================
--- gcc/config/arm/arm.h (revision 216547)
+++ gcc/config/arm/arm.h (working copy)
@@ -167,7 +167,7 @@
{ \
builtin_define ("__ARM_ARCH_EXT_IDIV__"); \
builtin_define ("__ARM_FEATURE_IDIV__"); \
- }
+ } \
} while (0)
#include "config/arm/arm-opts.h"
>
> Ramana
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [COMMITTED][PATCH][ARM]Add ACLE 2.0 predefined marco __ARM_FEATURE_IDIV
2014-10-22 10:13 ` [COMMITTED][PATCH][ARM]Add " Jiong Wang
@ 2014-10-23 10:09 ` Ramana Radhakrishnan
2014-10-23 10:31 ` Renlin Li
0 siblings, 1 reply; 6+ messages in thread
From: Ramana Radhakrishnan @ 2014-10-23 10:09 UTC (permalink / raw)
To: Jiong Wang; +Cc: Ramana Radhakrishnan, Renlin Li, gcc-patches
On Wed, Oct 22, 2014 at 11:02 AM, Jiong Wang <jiong.wang@arm.com> wrote:
>
> On 21/10/14 15:30, Ramana Radhakrishnan wrote:
>>
>> On Mon, Oct 13, 2014 at 3:15 PM, Renlin Li <renlin.li@arm.com> wrote:
>>>
>>> Hi all,
>>>
>>> This is a simple patch to add missing __ARM_FEATURE_IDIV__ predefined
>>> marco(ACLE 2.0) into TARGET_CPU_CPP_BUILTINS.
>>> Is it Okay to commit?
>>>
>>>
>>> gcc/ChangeLog:
>>>
>>> 2014-10-13 Renlin Li <Renlin.Li@arm.com>
>>>
>>> * config/arm/arm.h (TARGET_CPU_CPP_BUILTINS): Add ACLE 2.0
>>> predefined
>>> marco __ARM_FEATURE_IDIV__.
>>
>> Replace this with "Define __ARM_FEATURE_IDIV__." in the Changelog.
Are you sure that the ACLE documents this with trailing underscores ?
The copy that I have doesn't.
Ramana
>>
>> Ok with that change.
>
>
> committed on behalf of Renlin as 216547.
>
> 2014-10-22 Renlin Li <renlin.li@arm.com>
> gcc/
> * config/arm/arm.h (TARGET_CPU_CPP_BUILTINS): Define
> __ARM_FEATURE_IDIV__.
>
> Also fixed the missing '\' on the last line as obvious
>
> 2014-10-22 Jiong Wang <jiong.wang@arm.com>
>
> gcc/
> * config/arm/arm.h (TARGET_CPU_CPP_BUILTINS): Add missing '\'.
>
>
> Index: gcc/config/arm/arm.h
> ===================================================================
> --- gcc/config/arm/arm.h (revision 216547)
> +++ gcc/config/arm/arm.h (working copy)
> @@ -167,7 +167,7 @@
> { \
> builtin_define ("__ARM_ARCH_EXT_IDIV__"); \
> builtin_define ("__ARM_FEATURE_IDIV__"); \
> - }
> + } \
> } while (0)
> #include "config/arm/arm-opts.h"
>
>>
>> Ramana
>>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [COMMITTED][PATCH][ARM]Add ACLE 2.0 predefined marco __ARM_FEATURE_IDIV
2014-10-23 10:09 ` Ramana Radhakrishnan
@ 2014-10-23 10:31 ` Renlin Li
2014-11-04 9:46 ` Ramana Radhakrishnan
0 siblings, 1 reply; 6+ messages in thread
From: Renlin Li @ 2014-10-23 10:31 UTC (permalink / raw)
To: Ramana Radhakrishnan, Jiong Wang; +Cc: gcc-patches
> Are you sure that the ACLE documents this with trailing underscores ?
> The copy that I have doesn't.
You are right, it's my incaution. I have double checked, the macro
should be __ARM_FEATURE_IDIV.
Could you please do a obvious fix? Thank you so much!
Kind regards,
Renlin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [COMMITTED][PATCH][ARM]Add ACLE 2.0 predefined marco __ARM_FEATURE_IDIV
2014-10-23 10:31 ` Renlin Li
@ 2014-11-04 9:46 ` Ramana Radhakrishnan
0 siblings, 0 replies; 6+ messages in thread
From: Ramana Radhakrishnan @ 2014-11-04 9:46 UTC (permalink / raw)
To: Renlin Li; +Cc: Ramana Radhakrishnan, Jiong Wang, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 581 bytes --]
On Thu, Oct 23, 2014 at 11:30 AM, Renlin Li <renlin.li@arm.com> wrote:
>> Are you sure that the ACLE documents this with trailing underscores ?
>> The copy that I have doesn't.
>
>
> You are right, it's my incaution. I have double checked, the macro should be
> __ARM_FEATURE_IDIV.
>
> Could you please do a obvious fix? Thank you so much!
applied this as obvious.
Ramana
2014-11-04 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
* config/arm/arm.h (TARGET_CPU_CPP_BUILTINS): Fix typo in definition
of __ARM_FEATURE_IDIV.
>
> Kind regards,
> Renlin
>
[-- Attachment #2: idiv-patch.txt --]
[-- Type: text/plain, Size: 447 bytes --]
Index: gcc/config/arm/arm.h
===================================================================
--- gcc/config/arm/arm.h (revision 217070)
+++ gcc/config/arm/arm.h (working copy)
@@ -166,7 +166,7 @@
if (TARGET_IDIV) \
{ \
builtin_define ("__ARM_ARCH_EXT_IDIV__"); \
- builtin_define ("__ARM_FEATURE_IDIV__"); \
+ builtin_define ("__ARM_FEATURE_IDIV"); \
} \
} while (0)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-11-04 9:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-13 14:19 [PATCH][ARM]Add ACLE 2.0 predefined marco __ARM_FEATURE_IDIV Renlin Li
2014-10-21 14:46 ` Ramana Radhakrishnan
2014-10-22 10:13 ` [COMMITTED][PATCH][ARM]Add " Jiong Wang
2014-10-23 10:09 ` Ramana Radhakrishnan
2014-10-23 10:31 ` Renlin Li
2014-11-04 9:46 ` Ramana Radhakrishnan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).