[PATCH] testsuite/arm: Improve unsigned-float.c

[PATCH] testsuite/arm: Improve unsigned-float.c

[Christophe Lyon]

The test requires an FPU, so use -march=armv7-a+fp -mfpu=auto instead
of -march=armv7-a.

We also remove dg-require-effective-target arm_fp_ok, but keep
dg-add-options arm_fp: this enables the test to pass on arm-eabi
configured with default cpu/fpu/mode.

dg-require-effective-target arm_fp_ok fails on such a configuration
for lack of FPU, since dg-options are not taken into account by
dg-require-effective-target.

Add -march=armv7-a+fp -mfpu=auto is sufficient for arm_fp options to
be acceptable.

This enables the test to pass on all the arm-eabi configurations I'm
testing, as well as arm-linux-gnueabi when forcing -march=armv5t.

2021-04-22  Christophe Lyon  <christophe.lyon@linaro.org>

	gcc/testsuite/
	* gcc.target/arm/unsigned-float.c: Remove arm_fp_ok, adjust
	dg-options.
---
 gcc/testsuite/gcc.target/arm/unsigned-float.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gcc/testsuite/gcc.target/arm/unsigned-float.c b/gcc/testsuite/gcc.target/arm/unsigned-float.c
index ad589d9..ea3abc7 100644
--- a/gcc/testsuite/gcc.target/arm/unsigned-float.c
+++ b/gcc/testsuite/gcc.target/arm/unsigned-float.c
@@ -1,8 +1,8 @@
 /* { dg-do compile } */
-/* { dg-require-effective-target arm_fp_ok } */
-/* { dg-skip-if "need fp instructions" { *-*-* } { "-mfloat-abi=soft" } { "" } } */
 /* { dg-skip-if "-mpure-code supports M-profile only" { *-*-* } { "-mpure-code" } } */
-/* { dg-options "-march=armv7-a -O1" } */
+/* { dg-options "-march=armv7-a+fp -mfpu=auto -O1" } */
+/* Do not require arm_ok effective target to avoid skipping on arm-eabi with
+   default configure options.  */
 /* { dg-add-options arm_fp } */
 
 
-- 
2.7.4

Re: [PATCH] testsuite/arm: Improve unsigned-float.c

[Christophe Lyon]

ping?

On Thu, 22 Apr 2021 at 15:32, Christophe Lyon
<christophe.lyon@linaro.org> wrote:
>
> The test requires an FPU, so use -march=armv7-a+fp -mfpu=auto instead
> of -march=armv7-a.
>
> We also remove dg-require-effective-target arm_fp_ok, but keep
> dg-add-options arm_fp: this enables the test to pass on arm-eabi
> configured with default cpu/fpu/mode.
>
> dg-require-effective-target arm_fp_ok fails on such a configuration
> for lack of FPU, since dg-options are not taken into account by
> dg-require-effective-target.
>
> Add -march=armv7-a+fp -mfpu=auto is sufficient for arm_fp options to
> be acceptable.
>
> This enables the test to pass on all the arm-eabi configurations I'm
> testing, as well as arm-linux-gnueabi when forcing -march=armv5t.
>
> 2021-04-22  Christophe Lyon  <christophe.lyon@linaro.org>
>
>         gcc/testsuite/
>         * gcc.target/arm/unsigned-float.c: Remove arm_fp_ok, adjust
>         dg-options.
> ---
>  gcc/testsuite/gcc.target/arm/unsigned-float.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/arm/unsigned-float.c b/gcc/testsuite/gcc.target/arm/unsigned-float.c
> index ad589d9..ea3abc7 100644
> --- a/gcc/testsuite/gcc.target/arm/unsigned-float.c
> +++ b/gcc/testsuite/gcc.target/arm/unsigned-float.c
> @@ -1,8 +1,8 @@
>  /* { dg-do compile } */
> -/* { dg-require-effective-target arm_fp_ok } */
> -/* { dg-skip-if "need fp instructions" { *-*-* } { "-mfloat-abi=soft" } { "" } } */
>  /* { dg-skip-if "-mpure-code supports M-profile only" { *-*-* } { "-mpure-code" } } */
> -/* { dg-options "-march=armv7-a -O1" } */
> +/* { dg-options "-march=armv7-a+fp -mfpu=auto -O1" } */
> +/* Do not require arm_ok effective target to avoid skipping on arm-eabi with
> +   default configure options.  */
>  /* { dg-add-options arm_fp } */
>
>
> --
> 2.7.4
>

Re: [PATCH] testsuite/arm: Improve unsigned-float.c

[Richard Earnshaw]

On 22/04/2021 14:32, Christophe Lyon via Gcc-patches wrote:
> The test requires an FPU, so use -march=armv7-a+fp -mfpu=auto instead
> of -march=armv7-a.
> 
> We also remove dg-require-effective-target arm_fp_ok, but keep
> dg-add-options arm_fp: this enables the test to pass on arm-eabi
> configured with default cpu/fpu/mode.
> 
> dg-require-effective-target arm_fp_ok fails on such a configuration
> for lack of FPU, since dg-options are not taken into account by
> dg-require-effective-target.
> 
> Add -march=armv7-a+fp -mfpu=auto is sufficient for arm_fp options to
> be acceptable.
> 
> This enables the test to pass on all the arm-eabi configurations I'm
> testing, as well as arm-linux-gnueabi when forcing -march=armv5t.
> 
> 2021-04-22  Christophe Lyon  <christophe.lyon@linaro.org>
> 
> 	gcc/testsuite/
> 	* gcc.target/arm/unsigned-float.c: Remove arm_fp_ok, adjust
> 	dg-options.
> ---
>   gcc/testsuite/gcc.target/arm/unsigned-float.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/gcc/testsuite/gcc.target/arm/unsigned-float.c b/gcc/testsuite/gcc.target/arm/unsigned-float.c
> index ad589d9..ea3abc7 100644
> --- a/gcc/testsuite/gcc.target/arm/unsigned-float.c
> +++ b/gcc/testsuite/gcc.target/arm/unsigned-float.c
> @@ -1,8 +1,8 @@
>   /* { dg-do compile } */
> -/* { dg-require-effective-target arm_fp_ok } */
> -/* { dg-skip-if "need fp instructions" { *-*-* } { "-mfloat-abi=soft" } { "" } } */
>   /* { dg-skip-if "-mpure-code supports M-profile only" { *-*-* } { "-mpure-code" } } */
> -/* { dg-options "-march=armv7-a -O1" } */
> +/* { dg-options "-march=armv7-a+fp -mfpu=auto -O1" } */
> +/* Do not require arm_ok effective target to avoid skipping on arm-eabi with
> +   default configure options.  */
>   /* { dg-add-options arm_fp } */
>   
>   

OK.
R.