[PING][PATCH v4 1/2] c++: implement __is_unsigned built-in trait

[Ken Matsui <kmatsui@cs.washington.edu>]

Ping for __is_unsigned built-in.

Sincerely,
Ken Matsui

On Sat, Jul 8, 2023 at 4:25 AM Ken Matsui <kmatsui@cs.washington.edu> wrote:
>
> Hi,
>
> Here is the benchmark result for is_unsigned:
>
> https://github.com/ken-matsui/gcc-benches/blob/main/is_unsigned.md#sat-jul--8-041510-am-pdt-2023
>
> Time: -66.908%
> Peak Memory Usage: -42.5139%
> Total Memory Usage: -46.3483%
>
> Sincerely,
> Ken Matsui
>
> On Sat, Jul 8, 2023 at 4:13 AM Ken Matsui <kmatsui@gcc.gnu.org> wrote:
> >
> > This patch implements built-in trait for std::is_unsigned.
> >
> > gcc/cp/ChangeLog:
> >
> >         * cp-trait.def: Define __is_unsigned.
> >         * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_UNSIGNED.
> >         * semantics.cc (trait_expr_value): Likewise.
> >         (finish_trait_expr): Likewise.
> >
> > gcc/testsuite/ChangeLog:
> >
> >         * g++.dg/ext/has-builtin-1.C: Test existence of __is_unsigned.
> >         * g++.dg/ext/is_unsigned.C: New test.
> >
> > Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
> > ---
> >  gcc/cp/constraint.cc                     |  3 ++
> >  gcc/cp/cp-trait.def                      |  1 +
> >  gcc/cp/semantics.cc                      |  4 ++
> >  gcc/testsuite/g++.dg/ext/has-builtin-1.C |  3 ++
> >  gcc/testsuite/g++.dg/ext/is_unsigned.C   | 47 ++++++++++++++++++++++++
> >  5 files changed, 58 insertions(+)
> >  create mode 100644 gcc/testsuite/g++.dg/ext/is_unsigned.C
> >
> > diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc
> > index 8cf0f2d0974..ec8de87d1a1 100644
> > --- a/gcc/cp/constraint.cc
> > +++ b/gcc/cp/constraint.cc
> > @@ -3751,6 +3751,9 @@ diagnose_trait_expr (tree expr, tree args)
> >      case CPTK_IS_UNION:
> >        inform (loc, "  %qT is not a union", t1);
> >        break;
> > +    case CPTK_IS_UNSIGNED:
> > +      inform (loc, "  %qT is not an unsigned type", t1);
> > +      break;
> >      case CPTK_IS_AGGREGATE:
> >        inform (loc, "  %qT is not an aggregate", t1);
> >        break;
> > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def
> > index 8b7fece0cc8..1a219243162 100644
> > --- a/gcc/cp/cp-trait.def
> > +++ b/gcc/cp/cp-trait.def
> > @@ -82,6 +82,7 @@ DEFTRAIT_EXPR (IS_TRIVIALLY_ASSIGNABLE, "__is_trivially_assignable", 2)
> >  DEFTRAIT_EXPR (IS_TRIVIALLY_CONSTRUCTIBLE, "__is_trivially_constructible", -1)
> >  DEFTRAIT_EXPR (IS_TRIVIALLY_COPYABLE, "__is_trivially_copyable", 1)
> >  DEFTRAIT_EXPR (IS_UNION, "__is_union", 1)
> > +DEFTRAIT_EXPR (IS_UNSIGNED, "__is_unsigned", 1)
> >  DEFTRAIT_EXPR (REF_CONSTRUCTS_FROM_TEMPORARY, "__reference_constructs_from_temporary", 2)
> >  DEFTRAIT_EXPR (REF_CONVERTS_FROM_TEMPORARY, "__reference_converts_from_temporary", 2)
> >  /* FIXME Added space to avoid direct usage in GCC 13.  */
> > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc
> > index 8fb47fd179e..2d48894d811 100644
> > --- a/gcc/cp/semantics.cc
> > +++ b/gcc/cp/semantics.cc
> > @@ -12118,6 +12118,9 @@ trait_expr_value (cp_trait_kind kind, tree type1, tree type2)
> >      case CPTK_IS_UNION:
> >        return type_code1 == UNION_TYPE;
> >
> > +    case CPTK_IS_UNSIGNED:
> > +      return TYPE_UNSIGNED (type1);
> > +
> >      case CPTK_IS_ASSIGNABLE:
> >        return is_xible (MODIFY_EXPR, type1, type2);
> >
> > @@ -12296,6 +12299,7 @@ finish_trait_expr (location_t loc, cp_trait_kind kind, tree type1, tree type2)
> >      case CPTK_IS_ENUM:
> >      case CPTK_IS_UNION:
> >      case CPTK_IS_SAME:
> > +    case CPTK_IS_UNSIGNED:
> >        break;
> >
> >      case CPTK_IS_LAYOUT_COMPATIBLE:
> > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++.dg/ext/has-builtin-1.C
> > index f343e153e56..20bf8e6cad5 100644
> > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C
> > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C
> > @@ -146,3 +146,6 @@
> >  #if !__has_builtin (__remove_cvref)
> >  # error "__has_builtin (__remove_cvref) failed"
> >  #endif
> > +#if !__has_builtin (__is_unsigned)
> > +# error "__has_builtin (__is_unsigned) failed"
> > +#endif
> > diff --git a/gcc/testsuite/g++.dg/ext/is_unsigned.C b/gcc/testsuite/g++.dg/ext/is_unsigned.C
> > new file mode 100644
> > index 00000000000..2bb45d209a7
> > --- /dev/null
> > +++ b/gcc/testsuite/g++.dg/ext/is_unsigned.C
> > @@ -0,0 +1,47 @@
> > +// { dg-do compile { target c++11 } }
> > +
> > +#include <testsuite_tr1.h>
> > +
> > +using namespace __gnu_test;
> > +
> > +#define SA(X) static_assert((X),#X)
> > +#define SA_TEST_CATEGORY(TRAIT, X, expect) \
> > +  SA(TRAIT(X) == expect);                  \
> > +  SA(TRAIT(const X) == expect);            \
> > +  SA(TRAIT(volatile X) == expect);         \
> > +  SA(TRAIT(const volatile X) == expect)
> > +
> > +SA_TEST_CATEGORY(__is_unsigned, void, false);
> > +
> > +SA_TEST_CATEGORY(__is_unsigned, bool, (bool(-1) > bool(0)));
> > +SA_TEST_CATEGORY(__is_unsigned, char, (char(-1) > char(0)));
> > +SA_TEST_CATEGORY(__is_unsigned, signed char, false);
> > +SA_TEST_CATEGORY(__is_unsigned, unsigned char, true);
> > +SA_TEST_CATEGORY(__is_unsigned, wchar_t, (wchar_t(-1) > wchar_t(0)));
> > +SA_TEST_CATEGORY(__is_unsigned, short, false);
> > +SA_TEST_CATEGORY(__is_unsigned, unsigned short, true);
> > +SA_TEST_CATEGORY(__is_unsigned, int, false);
> > +SA_TEST_CATEGORY(__is_unsigned, unsigned int, true);
> > +SA_TEST_CATEGORY(__is_unsigned, long, false);
> > +SA_TEST_CATEGORY(__is_unsigned, unsigned long, true);
> > +SA_TEST_CATEGORY(__is_unsigned, long long, false);
> > +SA_TEST_CATEGORY(__is_unsigned, unsigned long long, true);
> > +
> > +SA_TEST_CATEGORY(__is_unsigned, float, false);
> > +SA_TEST_CATEGORY(__is_unsigned, double, false);
> > +SA_TEST_CATEGORY(__is_unsigned, long double, false);
> > +
> > +#ifndef __STRICT_ANSI__
> > +// GNU Extensions.
> > +#ifdef __SIZEOF_INT128__
> > +SA_TEST_CATEGORY(__is_unsigned, unsigned __int128, true);
> > +SA_TEST_CATEGORY(__is_unsigned, __int128, false);
> > +#endif
> > +
> > +#ifdef _GLIBCXX_USE_FLOAT128
> > +SA_TEST_CATEGORY(__is_unsigned, __float128, false);
> > +#endif
> > +#endif
> > +
> > +// Sanity check.
> > +SA_TEST_CATEGORY(__is_unsigned, ClassType, false);
> > --
> > 2.41.0
> >