From: Hongtao Liu <crazylht@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: gcc-patches@gcc.gnu.org, Uros Bizjak <ubizjak@gmail.com>
Subject: Re: [PATCH] x86: Cast stride to __PTRDIFF_TYPE__ in AMX intrinsics
Date: Tue, 23 Aug 2022 10:05:16 +0800 [thread overview]
Message-ID: <CAMZc-bxGWVi6ODrsyKooQL5LhZVDNYmk8FSZzeuLJfkXVb0teA@mail.gmail.com> (raw)
In-Reply-To: <20220822170244.670691-1-hjl.tools@gmail.com>
On Tue, Aug 23, 2022 at 1:02 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On 64-bit Windows, long is 32 bits and can't be used as stride in memory
> operand when base is a pointer which is 64 bits. Cast stride to
> __PTRDIFF_TYPE__, instead of long.
Ok.
>
> PR target/106714
> * config/i386/amxtileintrin.h (_tile_loadd_internal): Cast to
> __PTRDIFF_TYPE__.
> (_tile_stream_loadd_internal): Likewise.
> (_tile_stored_internal): Likewise.
> ---
> gcc/config/i386/amxtileintrin.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/config/i386/amxtileintrin.h b/gcc/config/i386/amxtileintrin.h
> index 7b5a39eba72..06f18aa9bfb 100644
> --- a/gcc/config/i386/amxtileintrin.h
> +++ b/gcc/config/i386/amxtileintrin.h
> @@ -62,7 +62,7 @@ _tile_release (void)
> #define _tile_loadd_internal(dst,base,stride) \
> __asm__ volatile \
> ("{tileloadd\t(%0,%1,1), %%tmm"#dst"|tileloadd\t%%tmm"#dst", [%0+%1*1]}" \
> - :: "r" ((const void*) (base)), "r" ((long) (stride)))
> + :: "r" ((const void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride)))
>
> #define _tile_stream_loadd(dst,base,stride) \
> _tile_stream_loadd_internal (dst, base, stride)
> @@ -70,7 +70,7 @@ _tile_release (void)
> #define _tile_stream_loadd_internal(dst,base,stride) \
> __asm__ volatile \
> ("{tileloaddt1\t(%0,%1,1), %%tmm"#dst"|tileloaddt1\t%%tmm"#dst", [%0+%1*1]}" \
> - :: "r" ((const void*) (base)), "r" ((long) (stride)))
> + :: "r" ((const void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride)))
>
> #define _tile_stored(dst,base,stride) \
> _tile_stored_internal (dst, base, stride)
> @@ -78,7 +78,7 @@ _tile_release (void)
> #define _tile_stored_internal(src,base,stride) \
> __asm__ volatile \
> ("{tilestored\t%%tmm"#src", (%0,%1,1)|tilestored\t[%0+%1*1], %%tmm"#src"}" \
> - :: "r" ((void*) (base)), "r" ((long) (stride)) \
> + :: "r" ((void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride)) \
> : "memory")
>
> #define _tile_zero(dst) \
> --
> 2.37.2
>
--
BR,
Hongtao
next prev parent reply other threads:[~2022-08-23 2:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 17:02 H.J. Lu
2022-08-23 2:05 ` Hongtao Liu [this message]
2022-08-26 16:51 ` H.J. Lu
2022-08-29 0:24 ` Hongtao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZc-bxGWVi6ODrsyKooQL5LhZVDNYmk8FSZzeuLJfkXVb0teA@mail.gmail.com \
--to=crazylht@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).