Re: [PATCH] Fix incorrect insn type to avoid ICE in memory attr auto-detection.

[Hongtao Liu <crazylht@gmail.com>]

On Tue, Nov 8, 2022 at 9:17 AM liuhongt <hongtao.liu@intel.com> wrote:
>
> Memory attribute auto detection will check operand 2 for type sselog,
> and check operand 1 for type sselog1. For below 2 insns, there's no
> operand 2. Change type to sselog1.
>
> Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}.
> Ok for trunk?
Committed as an obvious fix.

>
> gcc/ChangeLog:
>
>         PR target/107540
>         * config/i386/sse.md (avx512f_movddup512<mask_name>): Change
>         type from sselog to sselog1.
>         (avx_movddup256<mask_name>): Ditto.
>
> gcc/testsuite/ChangeLog:
>
>         * gcc.target/i386/pr107540.c: New test.
> ---
>  gcc/config/i386/sse.md                   |  4 ++--
>  gcc/testsuite/gcc.target/i386/pr107540.c | 12 ++++++++++++
>  2 files changed, 14 insertions(+), 2 deletions(-)
>  create mode 100644 gcc/testsuite/gcc.target/i386/pr107540.c
>
> diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
> index fa93ae7bf21..4e8463addc3 100644
> --- a/gcc/config/i386/sse.md
> +++ b/gcc/config/i386/sse.md
> @@ -12203,7 +12203,7 @@ (define_insn "avx512f_movddup512<mask_name>"
>                      (const_int 6) (const_int 14)])))]
>    "TARGET_AVX512F"
>    "vmovddup\t{%1, %0<mask_operand2>|%0<mask_operand2>, %1}"
> -  [(set_attr "type" "sselog")
> +  [(set_attr "type" "sselog1")
>     (set_attr "prefix" "evex")
>     (set_attr "mode" "V8DF")])
>
> @@ -12234,7 +12234,7 @@ (define_insn "avx_movddup256<mask_name>"
>                      (const_int 2) (const_int 6)])))]
>    "TARGET_AVX && <mask_avx512vl_condition>"
>    "vmovddup\t{%1, %0<mask_operand2>|%0<mask_operand2>, %1}"
> -  [(set_attr "type" "sselog")
> +  [(set_attr "type" "sselog1")
>     (set_attr "prefix" "<mask_prefix>")
>     (set_attr "mode" "V4DF")])
>
> diff --git a/gcc/testsuite/gcc.target/i386/pr107540.c b/gcc/testsuite/gcc.target/i386/pr107540.c
> new file mode 100644
> index 00000000000..a0351ff9cb5
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/i386/pr107540.c
> @@ -0,0 +1,12 @@
> +/* { dg-do compile } */
> +/* { dg-options "-flive-range-shrinkage -mavx" } */
> +
> +typedef double __attribute__((__vector_size__ (32))) V;
> +
> +V v;
> +
> +void
> +foo (void)
> +{
> +  v = __builtin_ia32_movddup256 (v);
> +}
> --
> 2.27.0
>


--
BR,
Hongtao