Re: [PATCH] x86-64: Find a scratch register for large model profiling

["H.J. Lu" <hjl.tools@gmail.com>]

On Fri, Feb 2, 2024 at 4:07 AM <rep.dot.nop@gmail.com> wrote:
>
> On 2 February 2024 00:02:54 CET, "H.J. Lu" <hjl.tools@gmail.com> wrote:
> >On Thu, Feb 1, 2024 at 10:32 AM Jakub Jelinek <jakub@redhat.com> wrote:
> >>
> >> On Thu, Feb 01, 2024 at 10:15:30AM -0800, H.J. Lu wrote:
> >> > --- a/gcc/config/i386/i386.cc
> >> > +++ b/gcc/config/i386/i386.cc
> >> > @@ -22749,6 +22749,31 @@ current_fentry_section (const char **name)
> >> >    return true;
> >> >  }
> >> >
> >> > +/* Return an unused caller-saved register at entry for profile.  */
> >> > +
> >> > +static int
> >> > +x86_64_select_profile_regnum (bool r11_ok ATTRIBUTE_UNUSED)
> >> > +{
> >> > +  int i;
> >>
> >> Why not just return R10_REG here if flag_entry != 0 (i.e. keep existing
> >> behavior unless emitting profiler after prologue)?
> >
> >Fixed in v2.
>
> Nit: r10_ok is now superfluous, but lets wait for Jakub.
> thanks

Fixed in v3.

Thanks.

-- 
H.J.