public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb@kernel.org>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
	gcc-patches@gcc.gnu.org, keescook@chromium.org,
	 Jakub Jelinek <jakub@redhat.com>,
	Richard Biener <rguenther@suse.de>,
	 Hou Wenlong <houwenlong.hwl@antgroup.com>
Subject: Re: [PATCH] i386: Honour -mdirect-extern-access when calling __fentry__
Date: Fri, 12 May 2023 23:56:38 +0200	[thread overview]
Message-ID: <CAMj1kXEQdGAFpdTrsmcjnT1FjsAxke9=GPFTwBWDroQh8ecr1A@mail.gmail.com> (raw)
In-Reply-To: <CAFULd4bUCD-4MV97BhiV4Bo3K8euWOZh9QwOSGb=0azyBWBm3A@mail.gmail.com>

On Fri, 12 May 2023 at 19:05, Uros Bizjak <ubizjak@gmail.com> wrote:
>
> On Fri, May 12, 2023 at 4:07 PM Ard Biesheuvel <ardb@kernel.org> wrote:
>
> > > > > > Note that the GOT reference in question is in fact a data reference: we
> > > > > > explicitly load the address of __fentry__ from the GOT, which amounts to
> > > > > > eager binding, rather than emitting a PLT call that could bind eagerly,
> > > > > > lazily or directly at link time.
> > > > > >
> > > > > > gcc/ChangeLog:
> > > > > >
> > > > > >         * config/i386/i386.cc (x86_function_profiler): Take
> > > > > >           ix86_direct_extern_access into account when generating calls
> > > > > >           to __fentry__()
> > > > >
> > > > > HJ, is the patch OK with you?
> > > >
> > > > LGTM.
> > >
> > > OK then.
> > >
> >
> > Thanks all. Is anything expected of me at this point?
>
> Do you have write access to the repository? If not I can commit the
> patch for you

Yes, please.

, but you should state this [1] in your patch submission.
>
> [1] https://gcc.gnu.org/contribute.html
>

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>

Thanks,

      reply	other threads:[~2023-05-12 21:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09  8:58 Ard Biesheuvel
2023-05-10  9:16 ` Uros Bizjak
2023-05-10 22:03   ` H.J. Lu
2023-05-11  6:08     ` Uros Bizjak
2023-05-12 14:07       ` Ard Biesheuvel
2023-05-12 17:05         ` Uros Bizjak
2023-05-12 21:56           ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMj1kXEQdGAFpdTrsmcjnT1FjsAxke9=GPFTwBWDroQh8ecr1A@mail.gmail.com' \
    --to=ardb@kernel.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    --cc=houwenlong.hwl@antgroup.com \
    --cc=jakub@redhat.com \
    --cc=keescook@chromium.org \
    --cc=rguenther@suse.de \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).