From: Max Filippov <jcmvbkbc@gmail.com>
To: Alexey Lapshin <alexey.lapshin@espressif.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Alexey Gerenkov <alexey.gerenkov@espressif.com>,
Ivan Grokhotkov <ivan@espressif.com>
Subject: Re: [PATCH 2/3] gcc: xtensa: use dynconfig settings as builtin-macros
Date: Thu, 20 Jul 2023 08:25:15 -0700 [thread overview]
Message-ID: <CAMo8Bf+FUrx26LuGQb-sXD4_5G5mXjsaftVAcNKHU094SCY2CA@mail.gmail.com> (raw)
In-Reply-To: <764ac77b1311325242c0c2ab709fa31f5bf62f8f.camel@espressif.com>
On Thu, Jul 20, 2023 at 8:12 AM Alexey Lapshin
<alexey.lapshin@espressif.com> wrote:
>
> Oops, missed this loop while implementing...
>
> I had a problem with building esp chips multilib until added my changes.
>
> This loop looks like just defines a macro without value.
But it defines them with their respective values.
Just notice that it adds two leading underscores in front of the names.
> But the value must be set to make it work correctly.
> It uses builtin_define() instead builtin_define_with_int_value()
>
> I will check how it could be soved with the loop approach.
--
Thanks.
-- Max
next prev parent reply other threads:[~2023-07-20 15:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 14:34 [PATCH 0/3] Espressif xtensa chips multilib Alexey Lapshin
2023-07-20 14:35 ` [PATCH 1/3] gcc: xtensa: add mdynconfig option Alexey Lapshin
2023-07-20 14:37 ` [PATCH 2/3] gcc: xtensa: use dynconfig settings as builtin-macros Alexey Lapshin
2023-07-20 15:04 ` Max Filippov
2023-07-20 15:12 ` Alexey Lapshin
2023-07-20 15:25 ` Max Filippov [this message]
2023-07-20 16:10 ` Alexey Lapshin
2023-07-20 17:43 ` Max Filippov
2023-07-20 17:52 ` Alexey Lapshin
2023-07-20 17:54 ` Alexey Lapshin
2023-07-20 17:58 ` Max Filippov
2023-07-20 17:45 ` Alexey Lapshin
2023-07-20 17:55 ` Max Filippov
2023-07-20 14:37 ` [PATCH 3/3] gcc: xtensa: add xtensa*-esp*-elf multilib Alexey Lapshin
2023-12-11 7:35 ` [PATCH 0/3] Espressif xtensa chips multilib Alexey Lapshin
2024-04-01 12:16 ` [PATCH v2 1/2] gcc: xtensa: add mdynconfig option Alexey Lapshin
2024-04-01 12:16 ` [PATCH v2 2/2] gcc: xtensa: add xtensa*-esp*-elf multilib Alexey Lapshin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMo8Bf+FUrx26LuGQb-sXD4_5G5mXjsaftVAcNKHU094SCY2CA@mail.gmail.com \
--to=jcmvbkbc@gmail.com \
--cc=alexey.gerenkov@espressif.com \
--cc=alexey.lapshin@espressif.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ivan@espressif.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).