From: Max Filippov <jcmvbkbc@gmail.com>
To: "Takayuki 'January June' Suwa" <jjsuwa_sys3175@yahoo.co.jp>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 2/4] xtensa: Simplify conditional branch/move insn patterns
Date: Mon, 13 Jun 2022 17:32:15 -0700 [thread overview]
Message-ID: <CAMo8BfJJArcmN8_LU6WxiM8VegW3CgHbF7N=VYYhQ+k5Z5zB1Q@mail.gmail.com> (raw)
In-Reply-To: <b0333b8c-8c4b-8719-7375-66d43a6419ac@yahoo.co.jp>
On Sat, Jun 11, 2022 at 11:43 PM Takayuki 'January June' Suwa
<jjsuwa_sys3175@yahoo.co.jp> wrote:
>
> No need to describe the "false side" conditional insn patterns anymore.
>
> gcc/ChangeLog:
>
> * config/xtensa/xtensa-protos.h (xtensa_emit_branch):
> Remove the first argument.
> (xtensa_emit_bit_branch): Remove it because now called only from the
> output statement of *bittrue insn pattern.
> * config/xtensa/xtensa.cc (gen_int_relational): Remove the last
> argument 'p_invert', and make so that the condition is reversed by
> itself as needed.
> (xtensa_expand_conditional_branch): Share the common path, and remove
> condition inversion code.
> (xtensa_emit_branch, xtensa_emit_movcc): Simplify by removing the
> "false side" pattern.
> (xtensa_emit_bit_branch): Remove it because of the abovementioned
> reason, and move the function body to *bittrue insn pattern.
> * config/xtensa/xtensa.md (*bittrue): Transplant the output
> statement from removed xtensa_emit_bit_branch().
> (*bfalse, *ubfalse, *bitfalse, *maskfalse): Remove the "false side"
> insn patterns.
> ---
> gcc/config/xtensa/xtensa-protos.h | 3 +-
> gcc/config/xtensa/xtensa.cc | 111 ++++++++++------------------
> gcc/config/xtensa/xtensa.md | 117 ++++++++----------------------
> 3 files changed, 70 insertions(+), 161 deletions(-)
Regtested for target=xtensa-linux-uclibc, no new regressions.
Committed to master.
--
Thanks.
-- Max
prev parent reply other threads:[~2022-06-14 0:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-12 6:33 Takayuki 'January June' Suwa
2022-06-12 7:51 ` Max Filippov
2022-06-12 8:12 ` Takayuki 'January June' Suwa
2022-06-14 0:32 ` Max Filippov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMo8BfJJArcmN8_LU6WxiM8VegW3CgHbF7N=VYYhQ+k5Z5zB1Q@mail.gmail.com' \
--to=jcmvbkbc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jjsuwa_sys3175@yahoo.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).