public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] libgcc: arm: fix build for FDPIC target
@ 2024-03-22 20:14 Max Filippov
  2024-03-25 10:08 ` Christophe Lyon
  2024-03-25 18:23 ` Max Filippov
  0 siblings, 2 replies; 3+ messages in thread
From: Max Filippov @ 2024-03-22 20:14 UTC (permalink / raw)
  To: gcc-patches
  Cc: Nick Clifton, Richard Earnshaw, Ramana Radhakrishnan,
	Kyrylo Tkachov, Christophe Lyon, Max Filippov

libgcc/
	* unwind-arm-common.inc (__gnu_personality_sigframe_fdpic): Cast
	last argument of _Unwind_VRS_Set to void *.
---
 libgcc/unwind-arm-common.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libgcc/unwind-arm-common.inc b/libgcc/unwind-arm-common.inc
index 5453f38186b5..576f7e93e8a8 100644
--- a/libgcc/unwind-arm-common.inc
+++ b/libgcc/unwind-arm-common.inc
@@ -248,7 +248,7 @@ __gnu_personality_sigframe_fdpic (_Unwind_State state,
 	  + ARM_SIGCONTEXT_R0;
     /* Restore regs saved on stack by the kernel.  */
     for (i = 0; i < 16; i++)
-	_Unwind_VRS_Set (context, _UVRSC_CORE, i, _UVRSD_UINT32, sp + 4 * i);
+	_Unwind_VRS_Set (context, _UVRSC_CORE, i, _UVRSD_UINT32, (void *)(sp + 4 * i));
 
     return _URC_CONTINUE_UNWIND;
 }
-- 
2.39.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] libgcc: arm: fix build for FDPIC target
  2024-03-22 20:14 [PATCH] libgcc: arm: fix build for FDPIC target Max Filippov
@ 2024-03-25 10:08 ` Christophe Lyon
  2024-03-25 18:23 ` Max Filippov
  1 sibling, 0 replies; 3+ messages in thread
From: Christophe Lyon @ 2024-03-25 10:08 UTC (permalink / raw)
  To: Max Filippov, gcc-patches
  Cc: Nick Clifton, Richard Earnshaw, Ramana Radhakrishnan, Kyrylo Tkachov

Hi,

On 3/22/24 21:14, Max Filippov wrote:
> libgcc/
> 	* unwind-arm-common.inc (__gnu_personality_sigframe_fdpic): Cast
> 	last argument of _Unwind_VRS_Set to void *.
> ---
>   libgcc/unwind-arm-common.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libgcc/unwind-arm-common.inc b/libgcc/unwind-arm-common.inc
> index 5453f38186b5..576f7e93e8a8 100644
> --- a/libgcc/unwind-arm-common.inc
> +++ b/libgcc/unwind-arm-common.inc
> @@ -248,7 +248,7 @@ __gnu_personality_sigframe_fdpic (_Unwind_State state,
>   	  + ARM_SIGCONTEXT_R0;
>       /* Restore regs saved on stack by the kernel.  */
>       for (i = 0; i < 16; i++)
> -	_Unwind_VRS_Set (context, _UVRSC_CORE, i, _UVRSD_UINT32, sp + 4 * i);
> +	_Unwind_VRS_Set (context, _UVRSC_CORE, i, _UVRSD_UINT32, (void *)(sp + 4 * i));

LGTM (but I'm not a maintainer).

Thanks,

Christophe

>   
>       return _URC_CONTINUE_UNWIND;
>   }

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] libgcc: arm: fix build for FDPIC target
  2024-03-22 20:14 [PATCH] libgcc: arm: fix build for FDPIC target Max Filippov
  2024-03-25 10:08 ` Christophe Lyon
@ 2024-03-25 18:23 ` Max Filippov
  1 sibling, 0 replies; 3+ messages in thread
From: Max Filippov @ 2024-03-25 18:23 UTC (permalink / raw)
  To: gcc-patches
  Cc: Nick Clifton, Richard Earnshaw, Ramana Radhakrishnan,
	Kyrylo Tkachov, Christophe Lyon

On Fri, Mar 22, 2024 at 1:15 PM Max Filippov <jcmvbkbc@gmail.com> wrote:
>
> libgcc/
>         * unwind-arm-common.inc (__gnu_personality_sigframe_fdpic): Cast
>         last argument of _Unwind_VRS_Set to void *.
> ---
>  libgcc/unwind-arm-common.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Build-tested for arm-gnu-uclinuxfdpiceabi, committed as obvious.

-- 
Thanks.
-- Max

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-03-25 18:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-22 20:14 [PATCH] libgcc: arm: fix build for FDPIC target Max Filippov
2024-03-25 10:08 ` Christophe Lyon
2024-03-25 18:23 ` Max Filippov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).