public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Max Filippov <jcmvbkbc@gmail.com>
To: "Takayuki 'January June' Suwa" <jjsuwa_sys3175@yahoo.co.jp>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 2/4] xtensa: Make one_cmplsi2 optimizer-friendly
Date: Thu, 9 Jun 2022 15:12:21 -0700	[thread overview]
Message-ID: <CAMo8BfLQ+=5E4udHXQ+GA5n9=1-QPyA42xNgQaoX9_AC1vDQ5A@mail.gmail.com> (raw)
In-Reply-To: <9835da53-f201-fe51-c9a5-dcf9d7297941@yahoo.co.jp>

On Sun, May 29, 2022 at 4:00 AM Takayuki 'January June' Suwa
<jjsuwa_sys3175@yahoo.co.jp> wrote:
>
> In Xtensa ISA, there is no single machine instruction that calculates unary
> bitwise negation.  But a few optimizers assume that bitwise negation can be
> done by a single insn.
>
> As a result, '((x < 0) ? ~x : x)' cannot be optimized to '(x ^ (x >> 31))'
> ever before, for example.
>
> This patch relaxes such limitation, by putting the insn expansion off till
> the split pass.
>
> gcc/ChangeLog:
>
>         * config/xtensa/xtensa.md (one_cmplsi2):
>         Rearrange as an insn_and_split pattern.
>
> gcc/testsuite/ChangeLog:
>
>         * gcc.target/xtensa/one_cmpl_abs.c: New.
> ---
>   gcc/config/xtensa/xtensa.md                   | 26 +++++++++++++------
>   .../gcc.target/xtensa/one_cmpl_abs.c          |  9 +++++++
>   2 files changed, 27 insertions(+), 8 deletions(-)
>   create mode 100644 gcc/testsuite/gcc.target/xtensa/one_cmpl_abs.c

Regtested for target=xtensa-linux-uclibc, no new regressions.
Committed to master.

-- 
Thanks.
-- Max

      reply	other threads:[~2022-06-09 22:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-29 10:46 Takayuki 'January June' Suwa
2022-06-09 22:12 ` Max Filippov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMo8BfLQ+=5E4udHXQ+GA5n9=1-QPyA42xNgQaoX9_AC1vDQ5A@mail.gmail.com' \
    --to=jcmvbkbc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jjsuwa_sys3175@yahoo.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).