public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Joern Rennecke <joern.rennecke@embecosm.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>,
	Jivan Hakobyan <jivanhakobyan9@gmail.com>
Cc: Jeff Law <JeffreyALaw@gmail.com>
Subject: Re: [v2] RISC-V: Remove masking third operand of rotate instructions
Date: Thu, 18 May 2023 17:08:34 +0100	[thread overview]
Message-ID: <CAMqJFCoqXDuD9o54W5Y-ZfDNE279fs-9E5PicN7pxjuNkum7MQ@mail.gmail.com> (raw)
In-Reply-To: <CAMqJFCpT9F_4wfL5Nn2EQXhYryZ9Wrkf8vDGGQZT71FKph6=kQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

On Thu, 18 May 2023 at 16:37, Joern Rennecke <joern.rennecke@embecosm.com> wrote
in https://gcc.gnu.org/pipermail/gcc-patches/2023-May/618928.html :
>
> This breaks building libstdc++-v3 for
> -march=rv32imafdcv_zicsr_zifencei_zba_zbb_zbc_zbs_zve32f_zve32x_zve64d_zve64f_zve64x_zvl128b_zvl32b_zvl64b
> -mabi=ilp32f .

Sorry, I forgot the ChangeLog entry for my patch and missed the [v2]
part of the subject.

2023-05-18  Joern Rennecke  <joern.rennecke@embecosm.com>

gcc/ChangeLog:
        * config/riscv/constraints.md (DsS, DsD): Restore agreement
with shiftm1 mode attribute.

[-- Attachment #2: riscv-DsS-patch.txt --]
[-- Type: text/plain, Size: 572 bytes --]

diff --git a/gcc/config/riscv/constraints.md b/gcc/config/riscv/constraints.md
index c448e6b37e9..44525b2da49 100644
--- a/gcc/config/riscv/constraints.md
+++ b/gcc/config/riscv/constraints.md
@@ -65,13 +65,13 @@
   "@internal
    31 immediate"
   (and (match_code "const_int")
-       (match_test "ival == 31")))
+       (match_test "(ival & 31) == 31")))
 
 (define_constraint "DsD"
   "@internal
    63 immediate"
   (and (match_code "const_int")
-       (match_test "ival == 63")))
+       (match_test "(ival & 63) == 63")))
 
 (define_constraint "DbS"
   "@internal"

  reply	other threads:[~2023-05-18 16:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-18 15:37 Joern Rennecke
2023-05-18 16:08 ` Joern Rennecke [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-05-17 16:02 [v2] " Jivan Hakobyan
2023-05-17 19:06 ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMqJFCoqXDuD9o54W5Y-ZfDNE279fs-9E5PicN7pxjuNkum7MQ@mail.gmail.com \
    --to=joern.rennecke@embecosm.com \
    --cc=JeffreyALaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jivanhakobyan9@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).