Re: [PATCH v4 02/34] RISC-V: Add vlex_2.c

[Joern Rennecke <joern.rennecke@embecosm.com>]

On Wed, Jun 1, 2022 at 02:28:45 GMT 2022, zhongjuzhe
<juzhe.zhong@rivai.ai> wrote:
> gcc/testsuite/ChangeLog:
>
>        * gcc.target/riscv/rvv/intrinsic/vlex_2.c: New test.

These intrinsic test cases look like they have been machine generated.  And if
they aren't, they probably should (have) be(en).  I've been working on
stabilizing
a tree with the rvv patches merged, and found a number of tests had diverged
in intrinsic function naming, arguments taken, and/or return type.
Fixing this all
with global replaces in dozens of files is quite messy.  It would be
preferable if
such issues could be fixed by adjusting a generator file, and just re-generating
the generated files.  That's one of the reasons why the GPL makes a point of
asking to include source code.  Even if that is not strictly required
for the testsuite
for license reasons, it makes good sense to do that for maintenance reasons.
The generator file should then also add a note where in the source
tree to find the
generator file, and, where appropriate, notes which part(s) of the
generator file
is/are responsible for generating the test case.