* [PATCH] mips: Add appropriate linker flags when compiling with -static-pie
@ 2022-09-14 18:09 linted
2022-09-25 15:49 ` linted
0 siblings, 1 reply; 4+ messages in thread
From: linted @ 2022-09-14 18:09 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]
Hello,
This patch fixes missing flags when compiling with -static-pie on mips. I
made these modifications based on the previously submitted static pie patch
for arm as well as the working code for aarch64.
I tested with a host of mips-elf and checked with mips-sim. This patch was
also tested and used with uclibc-ng to generate static pie elfs.
This is my first patch for gcc, so please let me know if there is anything
I missed.
Signed-off-by: linted <linted@users.noreply.github.com>
---
gcc/config/mips/gnu-user.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/gcc/config/mips/gnu-user.h b/gcc/config/mips/gnu-user.h
index 6aad7192e69..b1c665b7f37 100644
--- a/gcc/config/mips/gnu-user.h
+++ b/gcc/config/mips/gnu-user.h
@@ -56,11 +56,12 @@ along with GCC; see the file COPYING3. If not see
#define GNU_USER_TARGET_LINK_SPEC "\
%{G*} %{EB} %{EL} %{mips*} %{shared} \
%{!shared: \
- %{!static: \
+ %{!static:%{!static-pie: \
%{rdynamic:-export-dynamic} \
%{mabi=n32: -dynamic-linker " GNU_USER_DYNAMIC_LINKERN32 "} \
%{mabi=64: -dynamic-linker " GNU_USER_DYNAMIC_LINKER64 "} \
- %{mabi=32: -dynamic-linker " GNU_USER_DYNAMIC_LINKER32 "}} \
+ %{mabi=32: -dynamic-linker " GNU_USER_DYNAMIC_LINKER32 "}}} \
+ %{static-pie:-Bstatic -pie --no-dynamic-linker -z text} \
%{static}} \
%{mabi=n32:-m" GNU_USER_LINK_EMULATIONN32 "} \
%{mabi=64:-m" GNU_USER_LINK_EMULATION64 "} \
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mips: Add appropriate linker flags when compiling with -static-pie
2022-09-14 18:09 [PATCH] mips: Add appropriate linker flags when compiling with -static-pie linted
@ 2022-09-25 15:49 ` linted
2022-10-12 18:17 ` Jeff Law
0 siblings, 1 reply; 4+ messages in thread
From: linted @ 2022-09-25 15:49 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 1709 bytes --]
Hello,
I'm just checking to see if anyone has had a chance to look at this.
Thank you
On Wed, Sep 14, 2022 at 2:09 PM linted <linted90@gmail.com> wrote:
> Hello,
>
> This patch fixes missing flags when compiling with -static-pie on mips. I
> made these modifications based on the previously submitted static pie patch
> for arm as well as the working code for aarch64.
>
> I tested with a host of mips-elf and checked with mips-sim. This patch was
> also tested and used with uclibc-ng to generate static pie elfs.
>
> This is my first patch for gcc, so please let me know if there is anything
> I missed.
>
>
>
> Signed-off-by: linted <linted@users.noreply.github.com>
> ---
> gcc/config/mips/gnu-user.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/config/mips/gnu-user.h b/gcc/config/mips/gnu-user.h
> index 6aad7192e69..b1c665b7f37 100644
> --- a/gcc/config/mips/gnu-user.h
> +++ b/gcc/config/mips/gnu-user.h
> @@ -56,11 +56,12 @@ along with GCC; see the file COPYING3. If not see
> #define GNU_USER_TARGET_LINK_SPEC "\
> %{G*} %{EB} %{EL} %{mips*} %{shared} \
> %{!shared: \
> - %{!static: \
> + %{!static:%{!static-pie: \
> %{rdynamic:-export-dynamic} \
> %{mabi=n32: -dynamic-linker " GNU_USER_DYNAMIC_LINKERN32 "} \
> %{mabi=64: -dynamic-linker " GNU_USER_DYNAMIC_LINKER64 "} \
> - %{mabi=32: -dynamic-linker " GNU_USER_DYNAMIC_LINKER32 "}} \
> + %{mabi=32: -dynamic-linker " GNU_USER_DYNAMIC_LINKER32 "}}} \
> + %{static-pie:-Bstatic -pie --no-dynamic-linker -z text} \
> %{static}} \
> %{mabi=n32:-m" GNU_USER_LINK_EMULATIONN32 "} \
> %{mabi=64:-m" GNU_USER_LINK_EMULATION64 "} \
> --
> 2.34.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mips: Add appropriate linker flags when compiling with -static-pie
2022-09-25 15:49 ` linted
@ 2022-10-12 18:17 ` Jeff Law
2022-10-20 17:29 ` linted
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Law @ 2022-10-12 18:17 UTC (permalink / raw)
To: gcc-patches
On 9/25/22 09:49, linted via Gcc-patches wrote:
> Hello,
> I'm just checking to see if anyone has had a chance to look at this.
>
> Thank you
>
> On Wed, Sep 14, 2022 at 2:09 PM linted <linted90@gmail.com> wrote:
>
>> Hello,
>>
>> This patch fixes missing flags when compiling with -static-pie on mips. I
>> made these modifications based on the previously submitted static pie patch
>> for arm as well as the working code for aarch64.
>>
>> I tested with a host of mips-elf and checked with mips-sim. This patch was
>> also tested and used with uclibc-ng to generate static pie elfs.
>>
>> This is my first patch for gcc, so please let me know if there is anything
>> I missed.
>>
>>
>>
>> Signed-off-by: linted <linted@users.noreply.github.com>
>> ---
>> gcc/config/mips/gnu-user.h | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/gcc/config/mips/gnu-user.h b/gcc/config/mips/gnu-user.h
>> index 6aad7192e69..b1c665b7f37 100644
>> --- a/gcc/config/mips/gnu-user.h
>> +++ b/gcc/config/mips/gnu-user.h
>> @@ -56,11 +56,12 @@ along with GCC; see the file COPYING3. If not see
>> #define GNU_USER_TARGET_LINK_SPEC "\
>> %{G*} %{EB} %{EL} %{mips*} %{shared} \
>> %{!shared: \
>> - %{!static: \
>> + %{!static:%{!static-pie: \
>> %{rdynamic:-export-dynamic} \
>> %{mabi=n32: -dynamic-linker " GNU_USER_DYNAMIC_LINKERN32 "} \
>> %{mabi=64: -dynamic-linker " GNU_USER_DYNAMIC_LINKER64 "} \
>> - %{mabi=32: -dynamic-linker " GNU_USER_DYNAMIC_LINKER32 "}} \
>> + %{mabi=32: -dynamic-linker " GNU_USER_DYNAMIC_LINKER32 "}}} \
>> + %{static-pie:-Bstatic -pie --no-dynamic-linker -z text} \
>> %{static}} \
This is a bit out of my usual areas of expertise. But what I find odd
here is that for -static we essentially do nothing, but for -static-pie
we need "-Bstatic -pie --no-dynamic-linker -z text". Is the -Bstatic
really needed for static-pie And if it is, then wouldn't it be needed
for -static as well? If you look carefully at aarch64, you'll see it
includes -Bstatic for -static.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mips: Add appropriate linker flags when compiling with -static-pie
2022-10-12 18:17 ` Jeff Law
@ 2022-10-20 17:29 ` linted
0 siblings, 0 replies; 4+ messages in thread
From: linted @ 2022-10-20 17:29 UTC (permalink / raw)
To: Jeff Law; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 2833 bytes --]
On Wed, Oct 12, 2022 at 2:18 PM Jeff Law via Gcc-patches <
gcc-patches@gcc.gnu.org> wrote:
>
> On 9/25/22 09:49, linted via Gcc-patches wrote:
> > Hello,
> > I'm just checking to see if anyone has had a chance to look at this.
> >
> > Thank you
> >
> > On Wed, Sep 14, 2022 at 2:09 PM linted <linted90@gmail.com> wrote:
> >
> >> Hello,
> >>
> >> This patch fixes missing flags when compiling with -static-pie on mips.
> I
> >> made these modifications based on the previously submitted static pie
> patch
> >> for arm as well as the working code for aarch64.
> >>
> >> I tested with a host of mips-elf and checked with mips-sim. This patch
> was
> >> also tested and used with uclibc-ng to generate static pie elfs.
> >>
> >> This is my first patch for gcc, so please let me know if there is
> anything
> >> I missed.
> >>
> >>
> >>
> >> Signed-off-by: linted <linted@users.noreply.github.com>
> >> ---
> >> gcc/config/mips/gnu-user.h | 5 +++--
> >> 1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/gcc/config/mips/gnu-user.h b/gcc/config/mips/gnu-user.h
> >> index 6aad7192e69..b1c665b7f37 100644
> >> --- a/gcc/config/mips/gnu-user.h
> >> +++ b/gcc/config/mips/gnu-user.h
> >> @@ -56,11 +56,12 @@ along with GCC; see the file COPYING3. If not see
> >> #define GNU_USER_TARGET_LINK_SPEC "\
> >> %{G*} %{EB} %{EL} %{mips*} %{shared} \
> >> %{!shared: \
> >> - %{!static: \
> >> + %{!static:%{!static-pie: \
> >> %{rdynamic:-export-dynamic} \
> >> %{mabi=n32: -dynamic-linker " GNU_USER_DYNAMIC_LINKERN32 "} \
> >> %{mabi=64: -dynamic-linker " GNU_USER_DYNAMIC_LINKER64 "} \
> >> - %{mabi=32: -dynamic-linker " GNU_USER_DYNAMIC_LINKER32 "}} \
> >> + %{mabi=32: -dynamic-linker " GNU_USER_DYNAMIC_LINKER32 "}}} \
> >> + %{static-pie:-Bstatic -pie --no-dynamic-linker -z text} \
> >> %{static}} \
>
> This is a bit out of my usual areas of expertise. But what I find odd
> here is that for -static we essentially do nothing, but for -static-pie
> we need "-Bstatic -pie --no-dynamic-linker -z text". Is the -Bstatic
> really needed for static-pie And if it is, then wouldn't it be needed
> for -static as well? If you look carefully at aarch64, you'll see it
> includes -Bstatic for -static.
>
>
> Jeff
>
This is a really good question. From what I can tell, the linker will treat
-Bstatic and -static identically. So when compiling with -static, adding a
-Bstatic is redundant since the -static will be passed on to the linker.
In the case of -static-pie, we need to explicitly specify -Bstatic so that
the linker will know that we want the binary to be statically linked since
there is no -static being passed on.
I am of the opinion that we should usually be explicit, but in this case, I
think it is more prudent to change less code.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-20 17:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-14 18:09 [PATCH] mips: Add appropriate linker flags when compiling with -static-pie linted
2022-09-25 15:49 ` linted
2022-10-12 18:17 ` Jeff Law
2022-10-20 17:29 ` linted
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).