From: Ian Lance Taylor <iant@golang.org>
To: Xi Ruoyao <xry111@xry111.site>
Cc: Jonathan Yong <10walls@gmail.com>,
Jakub Jelinek <jakub@redhat.com>, LIU Hao <lh_mouse@126.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Always define `WIN32_LEAN_AND_MEAN` before <windows.h>
Date: Sun, 5 Mar 2023 20:02:16 -0800 [thread overview]
Message-ID: <CAOyqgcV8NZXqAMyLvrRsynz8+KQceFWO_48hepHH-VdfvDM-jw@mail.gmail.com> (raw)
In-Reply-To: <7edb4e42526c2e410cf26bd078a4ad2eca0b8426.camel@xry111.site>
On Fri, Mar 3, 2023 at 10:47 PM Xi Ruoyao <xry111@xry111.site> wrote:
>
> On Sat, 2023-01-07 at 06:52 +0000, Jonathan Yong via Gcc-patches wrote:
> > On 1/6/23 18:10, Jakub Jelinek wrote:
> > > On Sat, Jan 07, 2023 at 02:01:05AM +0800, LIU Hao via Gcc-patches
> > > wrote:
> > > > libgomp/
> > > >
> > > > PR middle-end/108300
> > > > * config/mingw32/proc.c: Define `WIN32_LEAN_AND_MEAN`
> > > > before
> > > > <windows.h>.
> > >
> > > This change is ok for trunk.
> > >
> > > Jakub
> > >
> >
> > Pushed to master branch, thanks LH.
>
> The patch touches libgo (w/o mentioning it in the ChangeLog). I guess
> you need to contribute the libgo part into the upstream Go runtime or
> the change will be undone when Ian merges libgo next time.
Thanks, I've reverted the part of the patch that applies to libgo.
It's not worth changing upstream because gccgo doesn't support Windows
anyhow, and because that change is gone in the even-more-upstream
sources.
Ian
prev parent reply other threads:[~2023-03-06 4:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 18:01 LIU Hao
2023-01-06 18:10 ` Jakub Jelinek
2023-01-07 6:52 ` Jonathan Yong
2023-03-04 6:47 ` Xi Ruoyao
2023-03-06 4:02 ` Ian Lance Taylor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOyqgcV8NZXqAMyLvrRsynz8+KQceFWO_48hepHH-VdfvDM-jw@mail.gmail.com \
--to=iant@golang.org \
--cc=10walls@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=lh_mouse@126.com \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).