* libgo patch committed: Ignore __morestack in runtime.Callers
@ 2022-09-07 1:40 Ian Lance Taylor
2022-09-13 17:36 ` Ian Lance Taylor
0 siblings, 1 reply; 2+ messages in thread
From: Ian Lance Taylor @ 2022-09-07 1:40 UTC (permalink / raw)
To: gcc-patches, gofrontend-dev
[-- Attachment #1: Type: text/plain, Size: 382 bytes --]
This libgo patch ignores the __morestack function in runtime.Callers.
We were ignoring all functions starting with "__morestack_", but not
the function "__morestack" itself. Without this change, some tests
such as recover.go started failing recently, though I'm not sure
exactly what changed. Bootstrapped and ran Go testsuite on
x86_64-pc-linux-gnu. Committed to mainline.
Ian
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 925 bytes --]
c0852b51b7a68ada822955eb7ef83d933cc33e47
diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE
index ca797045d66..dce38e727a7 100644
--- a/gcc/go/gofrontend/MERGE
+++ b/gcc/go/gofrontend/MERGE
@@ -1,4 +1,4 @@
-d53e8a0e94e34dc609e34dd5e404debda2640cfb
+6543b7fc6da533eb976b37649a925e7fd5a521fa
The first line of this file holds the git revision number of the last
merge done from the gofrontend repository.
diff --git a/libgo/runtime/go-callers.c b/libgo/runtime/go-callers.c
index 31783696a08..1d4dee66279 100644
--- a/libgo/runtime/go-callers.c
+++ b/libgo/runtime/go-callers.c
@@ -107,7 +107,7 @@ callback (void *data, uintptr_t pc, const char *filename, int lineno,
p = function;
if (__builtin_strncmp (p, "___", 3) == 0)
++p;
- if (__builtin_strncmp (p, "__morestack_", 12) == 0)
+ if (__builtin_strncmp (p, "__morestack", 11) == 0)
return 0;
}
else if (filename != NULL)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: libgo patch committed: Ignore __morestack in runtime.Callers
2022-09-07 1:40 libgo patch committed: Ignore __morestack in runtime.Callers Ian Lance Taylor
@ 2022-09-13 17:36 ` Ian Lance Taylor
0 siblings, 0 replies; 2+ messages in thread
From: Ian Lance Taylor @ 2022-09-13 17:36 UTC (permalink / raw)
To: gcc-patches, gofrontend-dev
On Tue, Sep 6, 2022 at 6:40 PM Ian Lance Taylor <iant@golang.org> wrote:
>
> This libgo patch ignores the __morestack function in runtime.Callers.
> We were ignoring all functions starting with "__morestack_", but not
> the function "__morestack" itself. Without this change, some tests
> such as recover.go started failing recently, though I'm not sure
> exactly what changed. Bootstrapped and ran Go testsuite on
> x86_64-pc-linux-gnu. Committed to mainline.
I've also committed this patch to GCC 12 branch.
Ian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-13 17:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-07 1:40 libgo patch committed: Ignore __morestack in runtime.Callers Ian Lance Taylor
2022-09-13 17:36 ` Ian Lance Taylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).