From: Ian Lance Taylor <iant@golang.org>
To: soeren@soeren-tempel.net
Cc: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com
Subject: Re: [PATCH v2] libgo: Don't rely on GNU-specific strerror_r variant on Linux
Date: Wed, 30 Nov 2022 12:21:51 -0800 [thread overview]
Message-ID: <CAOyqgcWbMhL1wZ+uJ4WtKp27FB2LrOR90vLGY3h0DkZ+Vpx56w@mail.gmail.com> (raw)
In-Reply-To: <CAOyqgcUXZ3HjQ58yEHLPNg9bhwc8B0G-2SpynEeP=iw9Y+VOqw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]
On Tue, Nov 29, 2022 at 4:10 PM Ian Lance Taylor <iant@golang.org> wrote:
>
> On Tue, Nov 29, 2022 at 9:54 AM <soeren@soeren-tempel.net> wrote:
> >
> > From: Sören Tempel <soeren@soeren-tempel.net>
> >
> > On glibc, there are two versions of strerror_r: An XSI-compliant and a
> > GNU-specific version. The latter is only available on glibc. In order
> > to avoid duplicating the post-processing code of error messages, this
> > commit provides a separate strerror_go symbol which always refers to the
> > XSI-compliant version of strerror_r (even on glibc) by selectively
> > undefining the corresponding feature test macro.
> >
> > Previously, gofrontend assumed that the GNU-specific version of
> > strerror_r was always available on Linux (which isn't the case when
> > using a musl as a libc, for example). This commit thereby improves
> > compatibility with Linux systems that are not using glibc.
> >
> > Tested on x86_64 Alpine Linux Edge and Arch Linux (glibc 2.36).
>
> Thanks. I committed a version of this, as attached.
I've committed this follow-on patch for Hurd.
Ian
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 1063 bytes --]
91607eba8fe49c064192122ec60a3e03dd8f2515
diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE
index 984d8324004..a26f779557d 100644
--- a/gcc/go/gofrontend/MERGE
+++ b/gcc/go/gofrontend/MERGE
@@ -1,4 +1,4 @@
-fef6aa3c1678cdbe7dca454b2cebb369d8ba81bf
+1c5bfd57131b68b91d8400bb017f35d416f7aa7b
The first line of this file holds the git revision number of the last
merge done from the gofrontend repository.
diff --git a/libgo/runtime/go-strerror.c b/libgo/runtime/go-strerror.c
index 13d1d91df84..8ff5ffbdfec 100644
--- a/libgo/runtime/go-strerror.c
+++ b/libgo/runtime/go-strerror.c
@@ -12,7 +12,7 @@
exists to selectively undefine it and provides an alias to the
XSI-compliant version of strerror_r(3). */
-#ifdef __linux__
+#if defined(__linux__) || defined(__gnu_hurd__)
/* Force selection of XSI-compliant strerror_r by glibc. */
#undef XOPEN_SOURCE
@@ -21,7 +21,7 @@
#define _POSIX_C_SOURCE 200112L
#undef _GNU_SOURCE
-#endif /* __linux__ */
+#endif /* defined(__linux__) || defined(__gnu_hurd__) */
#include <string.h>
prev parent reply other threads:[~2022-11-30 20:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 17:43 [PATCH] " soeren
2022-11-29 17:54 ` [PATCH v2] " soeren
2022-11-30 0:10 ` Ian Lance Taylor
2022-11-30 20:21 ` Ian Lance Taylor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOyqgcWbMhL1wZ+uJ4WtKp27FB2LrOR90vLGY3h0DkZ+Vpx56w@mail.gmail.com \
--to=iant@golang.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gofrontend-dev@googlegroups.com \
--cc=soeren@soeren-tempel.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).