[PING][PATCH] c++: Introduce the extended attribute for asm declarations

[PING][PATCH] c++: Introduce the extended attribute for asm declarations

[Julian Waters]

Hi all, I'd like to ping the following patch

https://gcc.gnu.org/pipermail/gcc-patches/2023-November/636924.html

best regards,
Julian

Re: [PING][PATCH] c++: Introduce the extended attribute for asm declarations

[Xi Ruoyao]

On Mon, 2023-11-20 at 16:35 +0800, Julian Waters wrote:
> Hi all, I'd like to ping the following patch
> 
> https://gcc.gnu.org/pipermail/gcc-patches/2023-November/636924.html

You posted the patch Friday and then pinged it in Monday.  There is
literally zero working days for people to review the patch. 
https://gcc.gnu.org/contribute.html suggests to ping after at least two
weeks.  Sometimes I ping a patch after one week if it's urgent but 0
working days is definitely a no-go.

Also see the contribute patch for some basic style rules of the GCC code
and submitting a patch.  Bad-styled patches are often silently ignored.

On pure technical basis, you need to prove the new feature added is
really useful, for general use cases and not only your own use case. 
Once a feature is in GCC the developers need to pay efforts to maintain
it, so it won't be added unless it will benefit some general use case.

-- 
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University

Re: [PING][PATCH] c++: Introduce the extended attribute for asm declarations

[Julian Waters]

Hi Ruoyao,

Thanks for the tips, I'll keep it in mind

I've seen the contribution style guide, but it can be pretty difficult
to format gcc's source in a patch, at least for me :(

Noted, I'll add more descriptions to prove it's use case, thanks

best regards,
Julian

On Wed, Nov 22, 2023 at 4:28 AM Xi Ruoyao <xry111@xry111.site> wrote:
>
> On Mon, 2023-11-20 at 16:35 +0800, Julian Waters wrote:
> > Hi all, I'd like to ping the following patch
> >
> > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/636924.html
>
> You posted the patch Friday and then pinged it in Monday.  There is
> literally zero working days for people to review the patch.
> https://gcc.gnu.org/contribute.html suggests to ping after at least two
> weeks.  Sometimes I ping a patch after one week if it's urgent but 0
> working days is definitely a no-go.
>
> Also see the contribute patch for some basic style rules of the GCC code
> and submitting a patch.  Bad-styled patches are often silently ignored.
>
> On pure technical basis, you need to prove the new feature added is
> really useful, for general use cases and not only your own use case.
> Once a feature is in GCC the developers need to pay efforts to maintain
> it, so it won't be added unless it will benefit some general use case.
>
> --
> Xi Ruoyao <xry111@xry111.site>
> School of Aerospace Science and Technology, Xidian University