public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Akari Takahashi <akaritakahashioss@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] : [gcc/config/rs600/rs6000.cc][Fix typo] Add parentheses for if statement
Date: Fri, 9 Sep 2022 03:53:14 +0900	[thread overview]
Message-ID: <CAPzzfcvEr=d3LrEG1XXC9hCR3PjEcuDHYuv-hov_SyCLN9DiYw@mail.gmail.com> (raw)
In-Reply-To: <CAPzzfcuQcrsYZ+Ag-xfbVCCx2qzSS1hQgrAuWE8zE6vyb9Xayg@mail.gmail.com>

Hello:
I sent a pull request. Please review and merge.

Branch name:
patch/rc6000/fixtypo

Log:
commit d55c6c49e0f7760c0b85ee74eb9c2b4e68275a26 (HEAD -> patch/rc6000/fixtypo)
Author: Takahashi Akari <akaritakahashioss@gmail.com>
Date:   Fri Sep 9 03:37:34 2022 +0900

    [Fix typo] Add parentheses for if statement in line 18117.

Diff:
git diff 30c811f2bac73e63e0b461ba7ed3805b77898798
d55c6c49e0f7760c0b85ee74eb9c2b4e68275a26
diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc
index a656cb32a47..bcf634a146d 100644
--- a/gcc/config/rs6000/rs6000.cc
+++ b/gcc/config/rs6000/rs6000.cc
@@ -18114,7 +18114,7 @@ get_memref_parts (rtx mem, rtx *base,
HOST_WIDE_INT *offset,
                  HOST_WIDE_INT *size)
 {
   rtx addr_rtx;
-  if MEM_SIZE_KNOWN_P (mem)
+  if (MEM_SIZE_KNOWN_P (mem))
     *size = MEM_SIZE (mem);
   else
     return false;

Takahashi Akari
https://github.com/takahashi-akari
GPG Key: 9DD8 F529 83A0 3182 D318 6184 9309 E8D2 2FD4 4365

On Thu, Sep 8, 2022 at 8:20 AM Akari Takahashi
<akaritakahashioss@gmail.com> wrote:
>
> Hello:
> I am very interested in GCC and have joined the FSF membership.
> I found a small bug in the latest source code, so I report it.
>
> Patch:
> [Fix typo]Add parentheses for if statement in line 18117.
> gcc/config/rs600/rs6000.cc
>
> Diff:
> ----------------------------------
> diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc
> index bcf634a146d..a656cb32a47 100644
> --- a/gcc/config/rs6000/rs6000.cc
> +++ b/gcc/config/rs6000/rs6000.cc
> @@ -18114,7 +18114,7 @@ get_memref_parts (rtx mem, rtx *base,
> HOST_WIDE_INT *offset,
>                   HOST_WIDE_INT *size)
>  {
>    rtx addr_rtx;
> -  if (MEM_SIZE_KNOWN_P (mem))
> +  if MEM_SIZE_KNOWN_P (mem)
>      *size = MEM_SIZE (mem);
>    else
>      return false;
> ----------------------------------
>
> Takahashi Akari

  reply	other threads:[~2022-09-08 18:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07 23:20 Akari Takahashi
2022-09-08 18:53 ` Akari Takahashi [this message]
2022-09-10 15:26 ` Segher Boessenkool
2022-09-10 16:03   ` Akari Takahashi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPzzfcvEr=d3LrEG1XXC9hCR3PjEcuDHYuv-hov_SyCLN9DiYw@mail.gmail.com' \
    --to=akaritakahashioss@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).