Re: [PATCH] : [gcc/config/rs600/rs6000.cc][Fix typo] Add parentheses for if statement

[Akari Takahashi <akaritakahashioss@gmail.com>]

Hi, Segher!

I'd like to thank you from the bottom of my heart !
I was happy to see my name listed in the github repository as well.

This will motivate me to do my best to commit more to GCC.. :)

Best Regards,

Takahashi Akari
https://github.com/takahashi-akari
GPG Key: 9DD8 F529 83A0 3182 D318 6184 9309 E8D2 2FD4 4365

On Sun, Sep 11, 2022 at 12:28 AM Segher Boessenkool
<segher@kernel.crashing.org> wrote:
>
> Hi!
>
> Please cc: the rs6000 maintainers on rs6000 patches.
>
> On Thu, Sep 08, 2022 at 08:20:07AM +0900, Akari Takahashi via Gcc-patches wrote:
> > --- a/gcc/config/rs6000/rs6000.cc
> > +++ b/gcc/config/rs6000/rs6000.cc
> > @@ -18114,7 +18114,7 @@ get_memref_parts (rtx mem, rtx *base,
> > HOST_WIDE_INT *offset,
> >                   HOST_WIDE_INT *size)
> >  {
> >    rtx addr_rtx;
> > -  if (MEM_SIZE_KNOWN_P (mem))
> > +  if MEM_SIZE_KNOWN_P (mem)
> >      *size = MEM_SIZE (mem);
> >    else
> >      return false;
>
> This patch is generated backwards.
>
> I committed the following.  Thanks!
>
>
> Segher
>
>
> Subject: [PATCH] rs6000: Make an "if" statement more regular
>
> As Akari noticed, we have an unusual "if" statement without parentheses
> around the condition.  The condition is a macro that expands to
> something with parentheses in the right spot, but, let's make the code a
> little less surprising :-)
>
>
> 2022-09-10  Akari Takahashi  <akaritakahashioss@gmail.com>
>             Segher Boessenkool  <segher@kernel.crashing.org>
>
>         * config/rs6000/rs6000.cc (get_memref_parts): Regularize some code.
> ---
>  gcc/config/rs6000/rs6000.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc
> index a656cb32a472..bcf634a146de 100644
> --- a/gcc/config/rs6000/rs6000.cc
> +++ b/gcc/config/rs6000/rs6000.cc
> @@ -18114,7 +18114,7 @@ get_memref_parts (rtx mem, rtx *base, HOST_WIDE_INT *offset,
>                   HOST_WIDE_INT *size)
>  {
>    rtx addr_rtx;
> -  if MEM_SIZE_KNOWN_P (mem)
> +  if (MEM_SIZE_KNOWN_P (mem))
>      *size = MEM_SIZE (mem);
>    else
>      return false;