From: "Liu, Hongtao" <hongtao.liu@intel.com>
To: "Jiang, Haochen" <haochen.jiang@intel.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: RE: [PATCH] i386: Add AVX512BW to AVX512F in MASK_ISA2
Date: Thu, 30 Jun 2022 01:51:39 +0000 [thread overview]
Message-ID: <CY4PR1101MB215063D4FDDB23BF1C570E01E5BA9@CY4PR1101MB2150.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220630015031.104897-1-haochen.jiang@intel.com>
> -----Original Message-----
> From: Jiang, Haochen <haochen.jiang@intel.com>
> Sent: Thursday, June 30, 2022 9:51 AM
> To: gcc-patches@gcc.gnu.org
> Cc: ubizjak@gmail.com; Liu, Hongtao <hongtao.liu@intel.com>
> Subject: [PATCH] i386: Add AVX512BW to AVX512F in MASK_ISA2
>
> Hi all,
>
> I just found in MASK_ISA2_UNSET part, since AVX512BW is based on AVX512F,
> we should add OPTION_MASK_ISA2_AVX512BW_UNSET to AVX512F for
> maintainence convenience and logic correctness, or we will need to add all
> future ISAs based on AVX512BW in both AVX512F and AVX512BW. This will be
> easily forgot and might cause confusion.
>
> Also remove the redundant ones in this change.
>
> Regtested on x86_64-pc-linux-gnu. Ok for trunk?
LGTM.
>
> BRs,
> Haochen
>
> gcc/ChangeLog:
>
> * common/config/i386/i386-common.cc
> (OPTION_MASK_ISA2_AVX512F_UNSET):
> Add OPTION_MASK_ISA2_AVX512BW_UNSET, remove
> OPTION_MASK_ISA2_AVX512BF16_UNSET and
> OPTION_MASK_ISA2_AVX512FP16_UNSET.
> ---
> gcc/common/config/i386/i386-common.cc | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/common/config/i386/i386-common.cc
> b/gcc/common/config/i386/i386-common.cc
> index cb878163492..c0c2ad74d87 100644
> --- a/gcc/common/config/i386/i386-common.cc
> +++ b/gcc/common/config/i386/i386-common.cc
> @@ -315,11 +315,10 @@ along with GCC; see the file COPYING3. If not see
> | OPTION_MASK_ISA_SSE_UNSET)
>
> #define OPTION_MASK_ISA2_AVX512F_UNSET \
> - (OPTION_MASK_ISA2_AVX512BF16_UNSET \
> + (OPTION_MASK_ISA2_AVX512BW_UNSET \
> | OPTION_MASK_ISA2_AVX5124FMAPS_UNSET \
> | OPTION_MASK_ISA2_AVX5124VNNIW_UNSET \
> - | OPTION_MASK_ISA2_AVX512VP2INTERSECT_UNSET \
> - | OPTION_MASK_ISA2_AVX512FP16_UNSET)
> + | OPTION_MASK_ISA2_AVX512VP2INTERSECT_UNSET)
> #define OPTION_MASK_ISA2_GENERAL_REGS_ONLY_UNSET \
> OPTION_MASK_ISA2_SSE_UNSET
> #define OPTION_MASK_ISA2_AVX_UNSET OPTION_MASK_ISA2_AVX2_UNSET
> --
> 2.18.1
prev parent reply other threads:[~2022-06-30 1:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 1:50 Haochen Jiang
2022-06-30 1:51 ` Liu, Hongtao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR1101MB215063D4FDDB23BF1C570E01E5BA9@CY4PR1101MB2150.namprd11.prod.outlook.com \
--to=hongtao.liu@intel.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=haochen.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).