From: Mike Stump <mikestump@comcast.net>
To: Alejandro Colomar <alx@kernel.org>
Cc: Joseph Myers <josmyers@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v5 RESEND] C, ObjC: Add -Wunterminated-string-initialization
Date: Mon, 26 Feb 2024 11:32:33 -0800 [thread overview]
Message-ID: <DDC0A39F-48EC-429B-8DAB-1FF54323E06B@comcast.net> (raw)
In-Reply-To: <Zdy0rwW0fxgiX5TK@debian>
On Feb 26, 2024, at 7:56 AM, Alejandro Colomar <alx@kernel.org> wrote:
>
> I don't see an obvious order in that file. Where would you put the
> option?
The best place, would be to put it just after:
-Warray-bounds
-Warray-bounds=n
This is a functional style grouping that best mirrors the existing ordering. A runner up would be next to the string options or near a "terminating NUL", but after review, these don't seem more suitable.
> Do you want me to sort(1) it first, and then insert the new
> option in alphabetic order?
No. Let others play at that.
next prev parent reply other threads:[~2024-02-26 19:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 13:39 [PATCH v2] " Alejandro Colomar
2023-03-24 14:53 ` David Malcolm
2023-03-24 17:45 ` Alejandro Colomar
2023-03-24 17:58 ` David Malcolm
2023-04-20 17:17 ` Ping: " Alejandro Colomar
2023-10-01 0:55 ` Alejandro Colomar
2023-10-01 7:37 ` Martin Uecker
2023-10-01 11:35 ` Alejandro Colomar
2023-10-01 11:38 ` [PATCH v3] " Alejandro Colomar
2023-10-01 11:41 ` [PATCH v4] " Alejandro Colomar
2023-10-01 16:24 ` [PATCH v5] " Alejandro Colomar
2023-10-08 13:05 ` Ping: " Alejandro Colomar
2023-11-13 9:55 ` Alejandro Colomar
2024-02-06 10:45 ` [PATCH v5 RESEND] " Alejandro Colomar
2024-02-25 18:10 ` Mike Stump
2024-02-25 19:44 ` Alejandro Colomar
2024-02-26 15:27 ` Joseph Myers
2024-02-26 15:24 ` Joseph Myers
2024-02-26 15:56 ` Alejandro Colomar
2024-02-26 16:19 ` Joseph Myers
2024-02-26 19:54 ` Sandra Loosemore
2024-02-26 19:32 ` Mike Stump [this message]
2024-03-05 20:20 ` [PATCH v6] " Alejandro Colomar
2024-03-05 20:25 ` Alejandro Colomar
2024-03-05 20:33 ` [PATCH v7] " Alejandro Colomar
2024-03-05 22:42 ` Sandra Loosemore
2024-03-06 18:43 ` [PATCH v8] " Alejandro Colomar
2024-05-14 18:16 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDC0A39F-48EC-429B-8DAB-1FF54323E06B@comcast.net \
--to=mikestump@comcast.net \
--cc=alx@kernel.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=josmyers@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).