From: Alejandro Colomar <alx.manpages@gmail.com>
To: David Malcolm <dmalcolm@redhat.com>, gcc-patches@gcc.gnu.org
Cc: Alejandro Colomar <alx@kernel.org>,
Doug McIlroy <douglas.mcilroy@dartmouth.edu>,
"G. Branden Robinson" <g.branden.robinson@gmail.com>,
Ralph Corderoy <ralph@inputplus.co.uk>,
Dave Kemper <saint.snit@gmail.com>, Larry McVoy <lm@mcvoy.com>,
Andrew Pinski <pinskia@gmail.com>,
Jonathan Wakely <jwakely.gcc@gmail.com>,
Andrew Clayton <andrew@digital-domain.net>,
Martin Uecker <muecker@gwdg.de>
Subject: Ping: [PATCH v2] C, ObjC: Add -Wunterminated-string-initialization
Date: Thu, 20 Apr 2023 19:17:09 +0200 [thread overview]
Message-ID: <fdb778f9-369a-0106-4be6-9051b483fa6b@gmail.com> (raw)
In-Reply-To: <2061ea8e2d95d4904db84de34b7b25a0f426a4d9.camel@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 2465 bytes --]
Hi David,
On 3/24/23 18:58, David Malcolm wrote:
> On Fri, 2023-03-24 at 18:45 +0100, Alejandro Colomar wrote:
>> Hi David,
>>
>> On 3/24/23 15:53, David Malcolm wrote:
>>> On Fri, 2023-03-24 at 14:39 +0100, Alejandro Colomar via Gcc-
>>> patches
>>> wrote:
>>>> Warn about the following:
>>>>
>>>> char s[3] = "foo";
>>>>
>> [...]
>>
>>>> ---
>>>>
>>>> Hi,
>>>
>>> Hi Alex, thanks for the patch.
>>
>> :)
>>
>>>
>>>>
>>>> I sent v1 to the wrong list. This time I've made sure to write
>>>> to
>>>> gcc-patches@.
>>>
>>> Note that right now we're deep in bug-fixing/stabilization for GCC
>>> 13
>>> (and trunk is still tracking that effort), so your patch might be
>>> more
>>> suitable for GCC 14.
>>
>> Sure, no problem. Do you have a "next" branch where you pick patches
>> for after the release, or should I resend after the release?
>
> We don't; resending it after release is probably best.
>
>> Is
>> discussion of a patch reasonable now, or is it too much distracting
>> from your stabilization efforts?
>
> FWIW I'd prefer to postpone the discussion until after we branch for
> the release.
Sure. AFAIK it's fair game already to propose patches to GCC 14,
right? Would you please have a look into this? Thanks!
>
>>
>>>
>>>>
>>>> v2 adds some draft of a test, as suggested by Martin. However, I
>>>> don't
>>>> know yet how to write those, so the test is just a draft. But I
>>>> did
>>>> test the feature, by compiling GCC and compiling some small
>>>> program
>>>> with
>>>> it.
>>>
>>> Unfortunately the answer to the question "how do I run just one
>>> testcase in GCC's testsuite" is rather non-trivial; FWIW I've
>>> written
>>> up some notes on working with the GCC testsuite here:
>>> https://gcc-newbies-guide.readthedocs.io/en/latest/working-with-the-testsuite.html
>>
>> Hmm, I'll try following that; thanks! Is there anything obvious that
>> I might have missed, at first glance?
>
> The main thing is that there's a difference between compiling the test
> case "by hand", versus doing it through the test harness - the latter
> sets up the environment in a particular way, injects a particular set
> of flags, etc etc.
I forgot about this; I'll have a look into it when I find some time.
Cheers,
Alex
>
> Dave
>
--
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-04-20 17:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 13:39 Alejandro Colomar
2023-03-24 14:53 ` David Malcolm
2023-03-24 17:45 ` Alejandro Colomar
2023-03-24 17:58 ` David Malcolm
2023-04-20 17:17 ` Alejandro Colomar [this message]
2023-10-01 0:55 ` Alejandro Colomar
2023-10-01 7:37 ` Martin Uecker
2023-10-01 11:35 ` Alejandro Colomar
2023-10-01 11:38 ` [PATCH v3] " Alejandro Colomar
2023-10-01 11:41 ` [PATCH v4] " Alejandro Colomar
2023-10-01 16:24 ` [PATCH v5] " Alejandro Colomar
2023-10-08 13:05 ` Ping: " Alejandro Colomar
2023-11-13 9:55 ` Alejandro Colomar
2024-02-06 10:45 ` [PATCH v5 RESEND] " Alejandro Colomar
2024-02-25 18:10 ` Mike Stump
2024-02-25 19:44 ` Alejandro Colomar
2024-02-26 15:27 ` Joseph Myers
2024-02-26 15:24 ` Joseph Myers
2024-02-26 15:56 ` Alejandro Colomar
2024-02-26 16:19 ` Joseph Myers
2024-02-26 19:54 ` Sandra Loosemore
2024-02-26 19:32 ` Mike Stump
2024-03-05 20:20 ` [PATCH v6] " Alejandro Colomar
2024-03-05 20:25 ` Alejandro Colomar
2024-03-05 20:33 ` [PATCH v7] " Alejandro Colomar
2024-03-05 22:42 ` Sandra Loosemore
2024-03-06 18:43 ` [PATCH v8] " Alejandro Colomar
2024-05-14 18:16 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdb778f9-369a-0106-4be6-9051b483fa6b@gmail.com \
--to=alx.manpages@gmail.com \
--cc=alx@kernel.org \
--cc=andrew@digital-domain.net \
--cc=dmalcolm@redhat.com \
--cc=douglas.mcilroy@dartmouth.edu \
--cc=g.branden.robinson@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely.gcc@gmail.com \
--cc=lm@mcvoy.com \
--cc=muecker@gwdg.de \
--cc=pinskia@gmail.com \
--cc=ralph@inputplus.co.uk \
--cc=saint.snit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).