public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Wang, Yanzhang" <yanzhang.wang@intel.com>
To: Kito Cheng <kito.cheng@sifive.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	"juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>,
	"Li, Pan2" <pan2.li@intel.com>
Subject: RE: [PATCH v5] RISC-V: Add vector psabi checking.
Date: Mon, 12 Jun 2023 13:36:59 +0000	[thread overview]
Message-ID: <IA1PR11MB646668A8B1BDABE7D3DC7A59F254A@IA1PR11MB6466.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CALLt3TjcEnREbs8S7cvomptOzNbrn6GW6n4TuUO7b--LcRt_8Q@mail.gmail.com>

I found that add the -Wno-psabi to CFLAGS will be overrode by
dg-options. It seems we can only add this option to the third
arg of dg-runtest. Attach the dg-runtest comments,

# dg-runtest -- simple main loop useful to most testsuites
#
# OPTIONS is a set of options to always pass.
# DEFAULT_EXTRA_OPTIONS is a set of options to pass if the testcase
# doesn't specify any (with dg-option).

> -----Original Message-----
> From: Kito Cheng <kito.cheng@sifive.com>
> Sent: Monday, June 12, 2023 8:43 PM
> To: Wang, Yanzhang <yanzhang.wang@intel.com>
> Cc: gcc-patches@gcc.gnu.org; juzhe.zhong@rivai.ai; Li, Pan2
> <pan2.li@intel.com>
> Subject: Re: [PATCH v5] RISC-V: Add vector psabi checking.
> 
> Hi Yan-Zhang:
> 
> OK with one minor, go ahead IF the regression is clean.
> 
> Hi Pan:
> 
> Could you help to verify this patch and commit if the regression is clean?
> 
> thanks :)
> 
> > diff --git a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
> b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
> > index 5e69235a268..ad79d0e9a8d 100644
> > --- a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
> > +++ b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
> > @@ -43,7 +43,7 @@ dg-init
> >  # Main loop.
> >  set CFLAGS "$DEFAULT_CFLAGS -march=$gcc_march -mabi=$gcc_mabi -O3"
> 
> Add -Wno-psabi here rather than below, and also add it for
> g++.target/riscv/rvv/rvv.exp
> 
> >  dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/base/*.\[cS\]]] \
> > -       "" $CFLAGS
> > +       "-Wno-psabi" $CFLAGS
> >  gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/vsetvl/*.\[cS\]]]
> \
> >         "" $CFLAGS
> >  dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/autovec/*.\[cS\]]] \

  parent reply	other threads:[~2023-06-12 13:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-26 12:37 [PATCH] RISCV: " yanzhang.wang
2023-04-26 13:01 ` Kito Cheng
2023-04-27  2:40 ` [PATCH v2] " yanzhang.wang
2023-04-27  3:12 ` [PATCH v3] " yanzhang.wang
2023-04-27 15:41   ` Kito Cheng
2023-06-09  6:01 ` [PATCH v4] RISC-V: " yanzhang.wang
2023-06-09  9:51   ` Kito Cheng
2023-06-12  2:59     ` Wang, Yanzhang
2023-06-12  8:08 ` [PATCH v5] " yanzhang.wang
2023-06-12 12:43   ` Wang, Yanzhang
2023-06-12 12:43   ` Kito Cheng
2023-06-12 12:48     ` Li, Pan2
2023-06-13 11:36       ` Li, Pan2
2023-06-12 13:36     ` Wang, Yanzhang [this message]
2023-06-12 14:07       ` Kito Cheng
2023-06-12 14:18         ` Wang, Yanzhang
2023-06-12 14:34       ` Jeff Law
2023-06-12 14:52         ` Kito Cheng
2023-06-13  2:28           ` Wang, Yanzhang
2023-06-13  2:46 ` [PATCH v6] " yanzhang.wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=IA1PR11MB646668A8B1BDABE7D3DC7A59F254A@IA1PR11MB6466.namprd11.prod.outlook.com \
    --to=yanzhang.wang@intel.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=juzhe.zhong@rivai.ai \
    --cc=kito.cheng@sifive.com \
    --cc=pan2.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).