From: "Wang, Yanzhang" <yanzhang.wang@intel.com>
To: Kito Cheng <kito.cheng@sifive.com>, Jeff Law <jeffreyalaw@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>,
"Li, Pan2" <pan2.li@intel.com>
Subject: RE: [PATCH v5] RISC-V: Add vector psabi checking.
Date: Tue, 13 Jun 2023 02:28:10 +0000 [thread overview]
Message-ID: <IA1PR11MB6466DBCE63C03D99FA0FEBF9F255A@IA1PR11MB6466.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CALLt3Th+-0-z+i=NW=Zi0X7qeSBoQp2=keuENruXFoxU6jdZbg@mail.gmail.com>
I think it's ok to add it to specific cases and will not affect other cases.
There's not so many cases. And we can revert it after the finalization.
> -----Original Message-----
> From: Kito Cheng <kito.cheng@sifive.com>
> Sent: Monday, June 12, 2023 10:53 PM
> To: Jeff Law <jeffreyalaw@gmail.com>
> Cc: Wang, Yanzhang <yanzhang.wang@intel.com>; gcc-patches@gcc.gnu.org;
> juzhe.zhong@rivai.ai; Li, Pan2 <pan2.li@intel.com>
> Subject: Re: [PATCH v5] RISC-V: Add vector psabi checking.
>
> Hmmm, yeah, I think let's add it case by case...I assume we should get it
> rid before GCC 14, it is mostly used for the transition period before we
> settle down the ABI and for GCC 13.
>
> On Mon, Jun 12, 2023 at 10:34 PM Jeff Law <jeffreyalaw@gmail.com> wrote:
> >
> >
> >
> > On 6/12/23 07:36, Wang, Yanzhang via Gcc-patches wrote:
> > > I found that add the -Wno-psabi to CFLAGS will be overrode by
> > > dg-options. It seems we can only add this option to the third arg of
> > > dg-runtest. Attach the dg-runtest comments,
> > I think we default to -Wno-psabi to avoid triggering diagnostics in
> > the common case where we aren't concerned about such issues. So not a
> > surprise that we'll need to work a bit harder to get it added when we
> > do want to check for psabi issues.
> >
> > jeff
next prev parent reply other threads:[~2023-06-13 2:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 12:37 [PATCH] RISCV: " yanzhang.wang
2023-04-26 13:01 ` Kito Cheng
2023-04-27 2:40 ` [PATCH v2] " yanzhang.wang
2023-04-27 3:12 ` [PATCH v3] " yanzhang.wang
2023-04-27 15:41 ` Kito Cheng
2023-06-09 6:01 ` [PATCH v4] RISC-V: " yanzhang.wang
2023-06-09 9:51 ` Kito Cheng
2023-06-12 2:59 ` Wang, Yanzhang
2023-06-12 8:08 ` [PATCH v5] " yanzhang.wang
2023-06-12 12:43 ` Wang, Yanzhang
2023-06-12 12:43 ` Kito Cheng
2023-06-12 12:48 ` Li, Pan2
2023-06-13 11:36 ` Li, Pan2
2023-06-12 13:36 ` Wang, Yanzhang
2023-06-12 14:07 ` Kito Cheng
2023-06-12 14:18 ` Wang, Yanzhang
2023-06-12 14:34 ` Jeff Law
2023-06-12 14:52 ` Kito Cheng
2023-06-13 2:28 ` Wang, Yanzhang [this message]
2023-06-13 2:46 ` [PATCH v6] " yanzhang.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IA1PR11MB6466DBCE63C03D99FA0FEBF9F255A@IA1PR11MB6466.namprd11.prod.outlook.com \
--to=yanzhang.wang@intel.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@sifive.com \
--cc=pan2.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).