* [PATCH] RISC-V: Suppress bogus warning for VLS types
@ 2023-09-08 8:20 Juzhe-Zhong
2023-09-08 8:26 ` Kito Cheng
0 siblings, 1 reply; 3+ messages in thread
From: Juzhe-Zhong @ 2023-09-08 8:20 UTC (permalink / raw)
To: gcc-patches; +Cc: kito.cheng, kito.cheng, jeffreyalaw, rdapp.gcc, Juzhe-Zhong
This patch fixes over 100+ bogus FAILs due to experimental vector ABI warning.
gcc/ChangeLog:
* config/riscv/riscv.cc (riscv_pass_in_vector_p): Only allow RVV type.
---
gcc/config/riscv/riscv.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
index 9f0c8bbe9ed..81682d95ba4 100644
--- a/gcc/config/riscv/riscv.cc
+++ b/gcc/config/riscv/riscv.cc
@@ -4414,7 +4414,7 @@ riscv_pass_in_vector_p (const_tree type)
{
static int warned = 0;
- if (type && riscv_v_ext_mode_p (TYPE_MODE (type)) && !warned)
+ if (type && riscv_vector::lookup_vector_type_attribute (type) && !warned)
{
warning (OPT_Wpsabi,
"ABI for the vector type is currently in experimental stage and "
--
2.36.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RISC-V: Suppress bogus warning for VLS types
2023-09-08 8:20 [PATCH] RISC-V: Suppress bogus warning for VLS types Juzhe-Zhong
@ 2023-09-08 8:26 ` Kito Cheng
2023-09-08 8:31 ` Li, Pan2
0 siblings, 1 reply; 3+ messages in thread
From: Kito Cheng @ 2023-09-08 8:26 UTC (permalink / raw)
To: Juzhe-Zhong; +Cc: GCC Patches, Kito Cheng
[-- Attachment #1: Type: text/plain, Size: 969 bytes --]
LGTM
Juzhe-Zhong <juzhe.zhong@rivai.ai> 於 2023年9月8日 週五 16:20 寫道:
> This patch fixes over 100+ bogus FAILs due to experimental vector ABI
> warning.
>
> gcc/ChangeLog:
>
> * config/riscv/riscv.cc (riscv_pass_in_vector_p): Only allow RVV
> type.
>
> ---
> gcc/config/riscv/riscv.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
> index 9f0c8bbe9ed..81682d95ba4 100644
> --- a/gcc/config/riscv/riscv.cc
> +++ b/gcc/config/riscv/riscv.cc
> @@ -4414,7 +4414,7 @@ riscv_pass_in_vector_p (const_tree type)
> {
> static int warned = 0;
>
> - if (type && riscv_v_ext_mode_p (TYPE_MODE (type)) && !warned)
> + if (type && riscv_vector::lookup_vector_type_attribute (type) &&
> !warned)
> {
> warning (OPT_Wpsabi,
> "ABI for the vector type is currently in experimental stage
> and "
> --
> 2.36.3
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] RISC-V: Suppress bogus warning for VLS types
2023-09-08 8:26 ` Kito Cheng
@ 2023-09-08 8:31 ` Li, Pan2
0 siblings, 0 replies; 3+ messages in thread
From: Li, Pan2 @ 2023-09-08 8:31 UTC (permalink / raw)
To: Kito Cheng, Juzhe-Zhong; +Cc: GCC Patches, Kito Cheng
Committed, thanks Kito.
Pan
-----Original Message-----
From: Gcc-patches <gcc-patches-bounces+pan2.li=intel.com@gcc.gnu.org> On Behalf Of Kito Cheng via Gcc-patches
Sent: Friday, September 8, 2023 4:27 PM
To: Juzhe-Zhong <juzhe.zhong@rivai.ai>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>; Kito Cheng <kito.cheng@sifive.com>
Subject: Re: [PATCH] RISC-V: Suppress bogus warning for VLS types
LGTM
Juzhe-Zhong <juzhe.zhong@rivai.ai> 於 2023年9月8日 週五 16:20 寫道:
> This patch fixes over 100+ bogus FAILs due to experimental vector ABI
> warning.
>
> gcc/ChangeLog:
>
> * config/riscv/riscv.cc (riscv_pass_in_vector_p): Only allow RVV
> type.
>
> ---
> gcc/config/riscv/riscv.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
> index 9f0c8bbe9ed..81682d95ba4 100644
> --- a/gcc/config/riscv/riscv.cc
> +++ b/gcc/config/riscv/riscv.cc
> @@ -4414,7 +4414,7 @@ riscv_pass_in_vector_p (const_tree type)
> {
> static int warned = 0;
>
> - if (type && riscv_v_ext_mode_p (TYPE_MODE (type)) && !warned)
> + if (type && riscv_vector::lookup_vector_type_attribute (type) &&
> !warned)
> {
> warning (OPT_Wpsabi,
> "ABI for the vector type is currently in experimental stage
> and "
> --
> 2.36.3
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-08 8:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-08 8:20 [PATCH] RISC-V: Suppress bogus warning for VLS types Juzhe-Zhong
2023-09-08 8:26 ` Kito Cheng
2023-09-08 8:31 ` Li, Pan2
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).