public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] RISC-V Regression test: Fix slp-perm-4.c FAIL for RVV
@ 2023-10-09 13:39 Juzhe-Zhong
  2023-10-09 13:51 ` Jeff Law
       [not found] ` <029BFC89F85887BC+94EE69CE-F68D-4BA2-88E6-EC4073C23430@rivai.ai>
  0 siblings, 2 replies; 4+ messages in thread
From: Juzhe-Zhong @ 2023-10-09 13:39 UTC (permalink / raw)
  To: gcc-patches; +Cc: rguenther, jeffreyalaw, Juzhe-Zhong

RVV vectorize it with stride5 load_lanes.

gcc/testsuite/ChangeLog:

	* gcc.dg/vect/slp-perm-4.c: Adapt test for stride5 load_lanes.

---
 gcc/testsuite/gcc.dg/vect/slp-perm-4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.dg/vect/slp-perm-4.c b/gcc/testsuite/gcc.dg/vect/slp-perm-4.c
index 107968f1f7c..f4bda39c837 100644
--- a/gcc/testsuite/gcc.dg/vect/slp-perm-4.c
+++ b/gcc/testsuite/gcc.dg/vect/slp-perm-4.c
@@ -115,4 +115,4 @@ int main (int argc, const char* argv[])
 
 /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" } } */
 /* { dg-final { scan-tree-dump-times "gaps requires scalar epilogue loop" 0 "vect" } } */
-/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 1 "vect" } } */
+/* { dg-final { scan-tree-dump-times "vectorizing stmts using SLP" 1 "vect" { target { ! { vect_load_lanes && vect_strided5 } } } } } */
-- 
2.36.3


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] RISC-V Regression test: Fix slp-perm-4.c FAIL for RVV
  2023-10-09 13:39 [PATCH] RISC-V Regression test: Fix slp-perm-4.c FAIL for RVV Juzhe-Zhong
@ 2023-10-09 13:51 ` Jeff Law
       [not found] ` <029BFC89F85887BC+94EE69CE-F68D-4BA2-88E6-EC4073C23430@rivai.ai>
  1 sibling, 0 replies; 4+ messages in thread
From: Jeff Law @ 2023-10-09 13:51 UTC (permalink / raw)
  To: Juzhe-Zhong, gcc-patches; +Cc: rguenther



On 10/9/23 07:39, Juzhe-Zhong wrote:
> RVV vectorize it with stride5 load_lanes.
> 
> gcc/testsuite/ChangeLog:
> 
> 	* gcc.dg/vect/slp-perm-4.c: Adapt test for stride5 load_lanes.
OK.

As a follow-up, would it make sense to test the .vect dump for something 
else in the ! {vec_load_lanes && vect_strided5 } case to verify that it 
does and continues to be vectorized for that configuration?

jeff

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] RISC-V Regression test: Fix slp-perm-4.c FAIL for RVV
       [not found] ` <029BFC89F85887BC+94EE69CE-F68D-4BA2-88E6-EC4073C23430@rivai.ai>
@ 2023-10-09 14:27   ` Jeff Law
  2023-10-09 14:38     ` Li, Pan2
  0 siblings, 1 reply; 4+ messages in thread
From: Jeff Law @ 2023-10-09 14:27 UTC (permalink / raw)
  To: juzhe.zhong; +Cc: gcc-patches, rguenther



On 10/9/23 08:21, juzhe.zhong wrote:
> Do you mean add a check whether it is vectorized or not?
Yes.

> 
> Sounds reasonable, I can add that in another patch.
Sounds good.  Thanks.

jeff

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] RISC-V Regression test: Fix slp-perm-4.c FAIL for RVV
  2023-10-09 14:27   ` Jeff Law
@ 2023-10-09 14:38     ` Li, Pan2
  0 siblings, 0 replies; 4+ messages in thread
From: Li, Pan2 @ 2023-10-09 14:38 UTC (permalink / raw)
  To: Jeff Law, juzhe.zhong; +Cc: gcc-patches, rguenther

Committed, thanks Jeff.

Pan

-----Original Message-----
From: Jeff Law <jeffreyalaw@gmail.com> 
Sent: Monday, October 9, 2023 10:28 PM
To: juzhe.zhong <juzhe.zhong@rivai.ai>
Cc: gcc-patches@gcc.gnu.org; rguenther@suse.de
Subject: Re: [PATCH] RISC-V Regression test: Fix slp-perm-4.c FAIL for RVV



On 10/9/23 08:21, juzhe.zhong wrote:
> Do you mean add a check whether it is vectorized or not?
Yes.

> 
> Sounds reasonable, I can add that in another patch.
Sounds good.  Thanks.

jeff

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-10-09 14:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-09 13:39 [PATCH] RISC-V Regression test: Fix slp-perm-4.c FAIL for RVV Juzhe-Zhong
2023-10-09 13:51 ` Jeff Law
     [not found] ` <029BFC89F85887BC+94EE69CE-F68D-4BA2-88E6-EC4073C23430@rivai.ai>
2023-10-09 14:27   ` Jeff Law
2023-10-09 14:38     ` Li, Pan2

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).