* [PATCH v1] RISC-V: Fix one warning of frm enum.
@ 2023-06-09 7:53 pan2.li
2023-06-09 8:08 ` juzhe.zhong
0 siblings, 1 reply; 4+ messages in thread
From: pan2.li @ 2023-06-09 7:53 UTC (permalink / raw)
To: gcc-patches
Cc: juzhe.zhong, rdapp.gcc, jeffreyalaw, pan2.li, yanzhang.wang, kito.cheng
From: Pan Li <pan2.li@intel.com>
This patch would like to fix one warning similar as below, and add the
link for where the values comes from.
./gcc/config/riscv/riscv-protos.h:260:13: warning: binary constants are
a C++14 feature or GCC extension
FRM_RNE = 0b000,
^~~~~
Signed-off-by: Pan Li <pan2.li@intel.com>
gcc/ChangeLog:
* config/riscv/riscv-protos.h (enum frm_field_enum): Adjust
literal to int.
---
gcc/config/riscv/riscv-protos.h | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/gcc/config/riscv/riscv-protos.h b/gcc/config/riscv/riscv-protos.h
index 38e4125424b..66c1f535d60 100644
--- a/gcc/config/riscv/riscv-protos.h
+++ b/gcc/config/riscv/riscv-protos.h
@@ -254,15 +254,18 @@ enum vxrm_field_enum
VXRM_RDN,
VXRM_ROD
};
-/* Rounding mode bitfield for floating point FRM. */
+/* Rounding mode bitfield for floating point FRM. The value of enum comes
+ from the below link.
+ https://github.com/riscv/riscv-isa-manual/blob/main/src/f-st-ext.adoc#floating-point-control-and-status-register
+ */
enum frm_field_enum
{
- FRM_RNE = 0b000,
- FRM_RTZ = 0b001,
- FRM_RDN = 0b010,
- FRM_RUP = 0b011,
- FRM_RMM = 0b100,
- FRM_DYN = 0b111
+ FRM_RNE = 0, /* Aka 0b000. */
+ FRM_RTZ = 1, /* Aka 0b001. */
+ FRM_RDN = 2, /* Aka 0b010. */
+ FRM_RUP = 3, /* Aka 0b011. */
+ FRM_RMM = 4, /* Aka 0b100. */
+ FRM_DYN = 7, /* Aka 0b111. */
};
opt_machine_mode vectorize_related_mode (machine_mode, scalar_mode,
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] RISC-V: Fix one warning of frm enum.
2023-06-09 7:53 [PATCH v1] RISC-V: Fix one warning of frm enum pan2.li
@ 2023-06-09 8:08 ` juzhe.zhong
2023-06-09 8:11 ` Kito Cheng
0 siblings, 1 reply; 4+ messages in thread
From: juzhe.zhong @ 2023-06-09 8:08 UTC (permalink / raw)
To: pan2.li, gcc-patches
Cc: Robin Dapp, jeffreyalaw, pan2.li, yanzhang.wang, kito.cheng
[-- Attachment #1: Type: text/plain, Size: 1786 bytes --]
Ok.
juzhe.zhong@rivai.ai
From: pan2.li
Date: 2023-06-09 15:53
To: gcc-patches
CC: juzhe.zhong; rdapp.gcc; jeffreyalaw; pan2.li; yanzhang.wang; kito.cheng
Subject: [PATCH v1] RISC-V: Fix one warning of frm enum.
From: Pan Li <pan2.li@intel.com>
This patch would like to fix one warning similar as below, and add the
link for where the values comes from.
./gcc/config/riscv/riscv-protos.h:260:13: warning: binary constants are
a C++14 feature or GCC extension
FRM_RNE = 0b000,
^~~~~
Signed-off-by: Pan Li <pan2.li@intel.com>
gcc/ChangeLog:
* config/riscv/riscv-protos.h (enum frm_field_enum): Adjust
literal to int.
---
gcc/config/riscv/riscv-protos.h | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/gcc/config/riscv/riscv-protos.h b/gcc/config/riscv/riscv-protos.h
index 38e4125424b..66c1f535d60 100644
--- a/gcc/config/riscv/riscv-protos.h
+++ b/gcc/config/riscv/riscv-protos.h
@@ -254,15 +254,18 @@ enum vxrm_field_enum
VXRM_RDN,
VXRM_ROD
};
-/* Rounding mode bitfield for floating point FRM. */
+/* Rounding mode bitfield for floating point FRM. The value of enum comes
+ from the below link.
+ https://github.com/riscv/riscv-isa-manual/blob/main/src/f-st-ext.adoc#floating-point-control-and-status-register
+ */
enum frm_field_enum
{
- FRM_RNE = 0b000,
- FRM_RTZ = 0b001,
- FRM_RDN = 0b010,
- FRM_RUP = 0b011,
- FRM_RMM = 0b100,
- FRM_DYN = 0b111
+ FRM_RNE = 0, /* Aka 0b000. */
+ FRM_RTZ = 1, /* Aka 0b001. */
+ FRM_RDN = 2, /* Aka 0b010. */
+ FRM_RUP = 3, /* Aka 0b011. */
+ FRM_RMM = 4, /* Aka 0b100. */
+ FRM_DYN = 7, /* Aka 0b111. */
};
opt_machine_mode vectorize_related_mode (machine_mode, scalar_mode,
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] RISC-V: Fix one warning of frm enum.
2023-06-09 8:08 ` juzhe.zhong
@ 2023-06-09 8:11 ` Kito Cheng
2023-06-09 8:14 ` Li, Pan2
0 siblings, 1 reply; 4+ messages in thread
From: Kito Cheng @ 2023-06-09 8:11 UTC (permalink / raw)
To: juzhe.zhong; +Cc: Robin Dapp, gcc-patches, jeffreyalaw, pan2.li, yanzhang.wang
[-- Attachment #1: Type: text/plain, Size: 2000 bytes --]
Lgtm
juzhe.zhong@rivai.ai <juzhe.zhong@rivai.ai>於 2023年6月9日 週五，16:08寫道：
> Ok.
>
>
>
> juzhe.zhong@rivai.ai
>
> From: pan2.li
> Date: 2023-06-09 15:53
> To: gcc-patches
> CC: juzhe.zhong; rdapp.gcc; jeffreyalaw; pan2.li; yanzhang.wang;
> kito.cheng
> Subject: [PATCH v1] RISC-V: Fix one warning of frm enum.
> From: Pan Li <pan2.li@intel.com>
>
> This patch would like to fix one warning similar as below, and add the
> link for where the values comes from.
>
> ./gcc/config/riscv/riscv-protos.h:260:13: warning: binary constants are
> a C++14 feature or GCC extension
> FRM_RNE = 0b000,
> ^~~~~
>
> Signed-off-by: Pan Li <pan2.li@intel.com>
>
> gcc/ChangeLog:
>
> * config/riscv/riscv-protos.h (enum frm_field_enum): Adjust
> literal to int.
> ---
> gcc/config/riscv/riscv-protos.h | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/gcc/config/riscv/riscv-protos.h
> b/gcc/config/riscv/riscv-protos.h
> index 38e4125424b..66c1f535d60 100644
> --- a/gcc/config/riscv/riscv-protos.h
> +++ b/gcc/config/riscv/riscv-protos.h
> @@ -254,15 +254,18 @@ enum vxrm_field_enum
> VXRM_RDN,
> VXRM_ROD
> };
> -/* Rounding mode bitfield for floating point FRM. */
> +/* Rounding mode bitfield for floating point FRM. The value of enum comes
> + from the below link.
> +
> https://github.com/riscv/riscv-isa-manual/blob/main/src/f-st-ext.adoc#floating-point-control-and-status-register
> + */
> enum frm_field_enum
> {
> - FRM_RNE = 0b000,
> - FRM_RTZ = 0b001,
> - FRM_RDN = 0b010,
> - FRM_RUP = 0b011,
> - FRM_RMM = 0b100,
> - FRM_DYN = 0b111
> + FRM_RNE = 0, /* Aka 0b000. */
> + FRM_RTZ = 1, /* Aka 0b001. */
> + FRM_RDN = 2, /* Aka 0b010. */
> + FRM_RUP = 3, /* Aka 0b011. */
> + FRM_RMM = 4, /* Aka 0b100. */
> + FRM_DYN = 7, /* Aka 0b111. */
> };
> opt_machine_mode vectorize_related_mode (machine_mode, scalar_mode,
> --
> 2.34.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v1] RISC-V: Fix one warning of frm enum.
2023-06-09 8:11 ` Kito Cheng
@ 2023-06-09 8:14 ` Li, Pan2
0 siblings, 0 replies; 4+ messages in thread
From: Li, Pan2 @ 2023-06-09 8:14 UTC (permalink / raw)
To: Kito Cheng, juzhe.zhong
Cc: Robin Dapp, gcc-patches, jeffreyalaw, Wang, Yanzhang
[-- Attachment #1: Type: text/plain, Size: 2438 bytes --]
Committed, thanks Kito and Juzhe.
Pan
From: Kito Cheng <kito.cheng@gmail.com>
Sent: Friday, June 9, 2023 4:11 PM
To: juzhe.zhong@rivai.ai
Cc: Robin Dapp <rdapp.gcc@gmail.com>; gcc-patches <gcc-patches@gcc.gnu.org>; jeffreyalaw <jeffreyalaw@gmail.com>; Li, Pan2 <pan2.li@intel.com>; Wang, Yanzhang <yanzhang.wang@intel.com>
Subject: Re: [PATCH v1] RISC-V: Fix one warning of frm enum.
Lgtm
juzhe.zhong@rivai.ai<mailto:juzhe.zhong@rivai.ai> <juzhe.zhong@rivai.ai<mailto:juzhe.zhong@rivai.ai>>於 2023年6月9日 週五，16:08寫道：
Ok.
juzhe.zhong@rivai.ai<mailto:juzhe.zhong@rivai.ai>
From: pan2.li<http://pan2.li>
Date: 2023-06-09 15:53
To: gcc-patches
CC: juzhe.zhong; rdapp.gcc; jeffreyalaw; pan2.li<http://pan2.li>; yanzhang.wang; kito.cheng
Subject: [PATCH v1] RISC-V: Fix one warning of frm enum.
From: Pan Li <pan2.li@intel.com<mailto:pan2.li@intel.com>>
This patch would like to fix one warning similar as below, and add the
link for where the values comes from.
./gcc/config/riscv/riscv-protos.h:260:13: warning: binary constants are
a C++14 feature or GCC extension
FRM_RNE = 0b000,
^~~~~
Signed-off-by: Pan Li <pan2.li@intel.com<mailto:pan2.li@intel.com>>
gcc/ChangeLog:
* config/riscv/riscv-protos.h (enum frm_field_enum): Adjust
literal to int.
---
gcc/config/riscv/riscv-protos.h | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/gcc/config/riscv/riscv-protos.h b/gcc/config/riscv/riscv-protos.h
index 38e4125424b..66c1f535d60 100644
--- a/gcc/config/riscv/riscv-protos.h
+++ b/gcc/config/riscv/riscv-protos.h
@@ -254,15 +254,18 @@ enum vxrm_field_enum
VXRM_RDN,
VXRM_ROD
};
-/* Rounding mode bitfield for floating point FRM. */
+/* Rounding mode bitfield for floating point FRM. The value of enum comes
+ from the below link.
+ https://github.com/riscv/riscv-isa-manual/blob/main/src/f-st-ext.adoc#floating-point-control-and-status-register
+ */
enum frm_field_enum
{
- FRM_RNE = 0b000,
- FRM_RTZ = 0b001,
- FRM_RDN = 0b010,
- FRM_RUP = 0b011,
- FRM_RMM = 0b100,
- FRM_DYN = 0b111
+ FRM_RNE = 0, /* Aka 0b000. */
+ FRM_RTZ = 1, /* Aka 0b001. */
+ FRM_RDN = 2, /* Aka 0b010. */
+ FRM_RUP = 3, /* Aka 0b011. */
+ FRM_RMM = 4, /* Aka 0b100. */
+ FRM_DYN = 7, /* Aka 0b111. */
};
opt_machine_mode vectorize_related_mode (machine_mode, scalar_mode,
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-09 8:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-09 7:53 [PATCH v1] RISC-V: Fix one warning of frm enum pan2.li
2023-06-09 8:08 ` juzhe.zhong
2023-06-09 8:11 ` Kito Cheng
2023-06-09 8:14 ` Li, Pan2
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).