From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Create common hooks structure shared between driver and cc1
Date: Wed, 25 May 2011 22:37:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1105252053290.9890@digraph.polyomino.org.uk> (raw)
In-Reply-To: <m3pqn6wnf8.fsf@fleche.redhat.com>
On Wed, 25 May 2011, Tom Tromey wrote:
> I believe the bugs referenced here were the problem:
>
> http://gcc.gnu.org/ml/gcc-patches/2008-03/msg01680.html
>
> Both these bugs use .INTERMEDIATE in their test cases, but it isn't
> clear to me that this is a sufficient condition.
The problem is that the reversion commit (r133652) doesn't mention
.INTERMEDIATE or .SECONDARY, so I can't identify the particular feature
that's causing the problems. But the problem feature isn't the includes
of the dependency files, since the hang still occurs with those includes
commented out.
I think a new attempt at this should be more incremental: separate pieces
might include:
* Changes to the names under which files are built (to go in the relevant
subdirectories).
* Changes to avoid the need for so many compilation rules (setting
variables for the relevant targets in one way or another).
* Changes to the compilation rules to use $(COMPILE).
* Changes to make $(COMPILE) generate automatic dependency files.
* Changes to actually use those files.
* Changes to ensure that, when the old manual dependencies are removed,
generated headers still get built in time.
* Changes to remove the old manual dependencies.
With each patch tested against the reliable reproducer in
<http://gcc.gnu.org/ml/gcc-patches/2008-03/msg01663.html>, it should
hopefully be possible to get the benefits of some of the above changes
without triggering the bug - and to understand better when the bug appears
just what the cause is and whether it can be worked around or not.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2011-05-25 21:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 0:25 Joseph S. Myers
2011-05-25 19:54 ` Joseph S. Myers
2011-05-25 21:40 ` Tom Tromey
2011-05-25 22:37 ` Joseph S. Myers [this message]
2011-05-25 23:56 ` Mike Stump
2011-05-26 0:16 ` Joseph S. Myers
2011-05-26 0:19 ` Mike Stump
2011-06-06 9:03 ` Ping " Joseph S. Myers
2011-06-10 14:56 ` Ping^2 " Joseph S. Myers
2011-06-14 17:29 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1105252053290.9890@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).