public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Create common hooks structure shared between driver and cc1
Date: Wed, 25 May 2011 21:40:00 -0000	[thread overview]
Message-ID: <m3pqn6wnf8.fsf@fleche.redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1105251921330.9890@digraph.polyomino.org.uk>	(Joseph S. Myers's message of "Wed, 25 May 2011 19:21:58 +0000 (UTC)")

>>>>> "Joseph" == Joseph S Myers <joseph@codesourcery.com> writes:

Joseph> dependencies.  For the latter, I looked again at Tom's reverted patch
Joseph> from March 2008 to use automatic dependency generation.  Although
Joseph> there is now a fixed GNU make release (since last July), and although
Joseph> I'd like to see automatic dependency generation go in (I hope Paolo
Joseph> may follow up on it as per
Joseph> <http://gcc.gnu.org/ml/gcc-patches/2008-03/msg01721.html>), actually
Joseph> getting it working looks like a potential rathole and I couldn't
Joseph> figure out from the 2008 thread what the makefile feature was that
Joseph> caused problems with a GNU make bug and whether it would be possible
Joseph> to disable use of that feature (instead having stupid dependencies of
Joseph> all objects on all headers) when using older versions of make (which
Joseph> would I think be desirable, to avoid forcing everyone to upgrade make
Joseph> immediately).

I believe the bugs referenced here were the problem:

    http://gcc.gnu.org/ml/gcc-patches/2008-03/msg01680.html

Both these bugs use .INTERMEDIATE in their test cases, but it isn't
clear to me that this is a sufficient condition.

My understanding is that the bug has been fixed in GNU make 3.82.  As
you point out, this has been out nearly a year; I think upgrading is not
an extreme hardship.

If you wanted to experiment with Makefile workarounds, I think the
simplest way would be to check out the revision before the patch was
reverted.  Trying to apply the patch to current trunk is indeed a
rathole.

Tom

  reply	other threads:[~2011-05-25 20:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-25  0:25 Joseph S. Myers
2011-05-25 19:54 ` Joseph S. Myers
2011-05-25 21:40   ` Tom Tromey [this message]
2011-05-25 22:37     ` Joseph S. Myers
2011-05-25 23:56   ` Mike Stump
2011-05-26  0:16     ` Joseph S. Myers
2011-05-26  0:19       ` Mike Stump
2011-06-06  9:03   ` Ping " Joseph S. Myers
2011-06-10 14:56     ` Ping^2 " Joseph S. Myers
2011-06-14 17:29   ` Ian Lance Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3pqn6wnf8.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).