From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, fortran <fortran@gcc.gnu.org>
Subject: Re: [Patch] OpenMP/Fortran: Fix handling of optional is_device_ptr + bind(C) [PR108546]
Date: Wed, 1 Mar 2023 13:42:28 +0100 [thread overview]
Message-ID: <Y/9ING8guGWaXSjk@tucnak> (raw)
In-Reply-To: <452ab67b-34f5-d816-436d-33f8f9ac44d4@codesourcery.com>
On Tue, Feb 28, 2023 at 05:18:25PM +0100, Tobias Burnus wrote:
> OpenMP/Fortran: Fix handling of optional is_device_ptr + bind(C) [PR108546]
>
> For is_device_ptr, optional checks should only be done before calling
> libgomp, afterwards they are NULL either because of absent or, by
> chance, because it is unallocated or unassociated (for pointers/allocatables).
>
> Additionally, it fixes an issue with explicit mapping for 'type(c_ptr)'.
>
> PR middle-end/108546
>
> gcc/fortran/ChangeLog:
>
> * trans-openmp.cc (gfc_trans_omp_clauses): Fix mapping of
> type(C_ptr) variables.
>
> gcc/ChangeLog:
>
> * omp-low.cc (lower_omp_target): Remove optional handling
> on the receiver side, i.e. inside target (data), for
> use_device_ptr.
>
> libgomp/ChangeLog:
>
> * testsuite/libgomp.fortran/is_device_ptr-3.f90: New test.
> * testsuite/libgomp.fortran/use_device_ptr-optional-4.f90: New test.
Ok, thanks.
Jakub
prev parent reply other threads:[~2023-03-01 12:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 16:18 Tobias Burnus
2023-03-01 12:42 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/9ING8guGWaXSjk@tucnak \
--to=jakub@redhat.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).