From: Jakub Jelinek <jakub@redhat.com>
To: Yash Shinde <Yash.Shinde@windriver.com>
Cc: gcc-patches@gcc.gnu.org, raj.khem@gmail.com,
Randy.MacLeod@windriver.com, Sundeep.Kokkonda@windriver.com
Subject: Re: [PATCH] libgcc_s: Use alias for __cpu_indicator_init instead of symver
Date: Thu, 23 Feb 2023 11:49:43 +0100 [thread overview]
Message-ID: <Y/dEx/q53EYhptkv@tucnak> (raw)
In-Reply-To: <20230222122333.28218-1-Yash.Shinde@windriver.com>
On Wed, Feb 22, 2023 at 04:23:33AM -0800, Yash Shinde wrote:
> From: Khem Raj <raj.khem@gmail.com>
>
> Adapter from
>
> https://gcc.gnu.org/ml/gcc-patches/2015-05/msg00899.html
>
> This fix was debated but hasnt been applied gcc upstream since
> they expect musl to support '@' in symbol versioning which is
> a sun/gnu versioning extention. This patch however avoids the
> need for the '@' symbols at all
This is an undesirable ABI change:
-__cpu_indicator_init@GCC_4.8.0 FUNC GLOBAL DEFAULT
-__cpu_model@GCC_4.8.0 OBJECT GLOBAL DEFAULT 16
+__cpu_indicator_init@@GCC_4.8.0 FUNC GLOBAL DEFAULT
+__cpu_model@@GCC_4.8.0 OBJECT GLOBAL DEFAULT 16
So, this is certainly unacceptable.
> libgcc/Changelog:
>
> 2015-05-11 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> * config/i386/cpuinfo.c (__cpu_indicator_init_local): Add.
> (__cpu_indicator_init@GCC_4.8.0, __cpu_model@GCC_4.8.0): Remove.
>
> * config/i386/t-linux (HOST_LIBGCC2_CFLAGS): Remove -DUSE_ELF_SYMVER.
>
> gcc/Changelog:
>
> 2015-05-11 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> * config/i386/i386-expand.c (ix86_expand_builtin): Make __builtin_cpu_init
> call __cpu_indicator_init_local instead of __cpu_indicator_init.
Jakub
prev parent reply other threads:[~2023-02-23 10:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 12:23 Yash Shinde
2023-02-23 10:49 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/dEx/q53EYhptkv@tucnak \
--to=jakub@redhat.com \
--cc=Randy.MacLeod@windriver.com \
--cc=Sundeep.Kokkonda@windriver.com \
--cc=Yash.Shinde@windriver.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).