From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch] OpenMP: Parse align clause in allocate directive in C/C++
Date: Thu, 9 Feb 2023 11:25:33 +0100 [thread overview]
Message-ID: <Y+TKHZSQkZ9wRVFV@tucnak> (raw)
In-Reply-To: <eb8772b3-fe96-cf40-b57e-3ae3a8d99afd@codesourcery.com>
On Thu, Feb 09, 2023 at 11:16:39AM +0100, Tobias Burnus wrote:
> Any further comments before I commit it?
> OpenMP: Parse align clause in allocate directive in C/C++
>
> gcc/c/ChangeLog:
>
> * c-parser.cc (c_parser_omp_allocate): Parse align
> clause and check for restrictions.
>
> gcc/cp/ChangeLog:
>
> * parser.cc (cp_parser_omp_allocate): Parse align
> clause.
The " and check for restrictions" part now applies also to C++...
> + if (expr != error_mark_node)
> + alignment = expr;
> + /* FIXME: Remove when adding check to semantic.cc; cf FIXME below. */
s/semantic.cc/semantics.cc/
Ok with those nits fixed.
Jakub
prev parent reply other threads:[~2023-02-09 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 17:44 Tobias Burnus
2023-01-31 12:09 ` Jakub Jelinek
2023-02-09 10:16 ` Tobias Burnus
2023-02-09 10:25 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+TKHZSQkZ9wRVFV@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).