From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch] libgomp: Fix 'target enter data' with always pointer
Date: Wed, 15 Feb 2023 11:13:47 +0100 [thread overview]
Message-ID: <Y+ywW0CQN3pxLfF5@tucnak> (raw)
In-Reply-To: <b21a2d3f-8d44-7311-ed3d-b06f70d9b7d4@codesourcery.com>
On Mon, Feb 13, 2023 at 09:28:15PM +0100, Tobias Burnus wrote:
> libgomp: Fix 'target enter data' with always pointer
>
> As GOMP_MAP_ALWAYS_POINTER operates on the previous map item, ensure that
> with 'target enter data' both are passed together to gomp_map_vars_internal.
>
> libgomp/ChangeLog:
>
> * target.c (gomp_map_vars_internal): Add 'i > 0' before doing a
> kind check.
> (GOMP_target_enter_exit_data): If the next map item is
> GOMP_MAP_ALWAYS_POINTER map it together with the current item.
> * testsuite/libgomp.fortran/target-enter-data-3.f90: New test.
8 spaces instead of tab, this won't get through the git pre-commit hook.
Otherwise LGTM.
Jakub
prev parent reply other threads:[~2023-02-15 10:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 20:28 Tobias Burnus
2023-02-15 10:13 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+ywW0CQN3pxLfF5@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).