From: Jakub Jelinek <jakub@redhat.com>
To: Andrew Stubbs <ams@codesourcery.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libgomp: fix hang on fatal error
Date: Wed, 19 Oct 2022 15:27:52 +0200 [thread overview]
Message-ID: <Y0/7WLIcxi0c1Mth@tucnak> (raw)
In-Reply-To: <c72ceaca-53e4-3deb-c0a6-57af9b2935a4@codesourcery.com>
On Fri, Oct 14, 2022 at 06:04:06PM +0100, Andrew Stubbs wrote:
> This patch fixes a problem in which fatal errors inside mutex-locked regions
> (i.e. basically anything in the plugin) will cause it to hang up trying to
> take the lock to clean everything up.
>
> Using abort() instead of exit(1) bypasses the atexit handlers and solves the
> problem.
>
> OK for mainline?
>
> Andrew
> libgomp: fix hang on fatal error
>
> Don't try to clean up if a fatal error occurs in libgomp. Typically the
> cleanup is not reentrant so we end up hung on a lock.
>
> libgomp/ChangeLog:
>
> * error.c (gomp_vfatal): Use abort instead of exit.
>
> diff --git a/libgomp/error.c b/libgomp/error.c
> index 50ed85eedb1..25548c14a82 100644
> --- a/libgomp/error.c
> +++ b/libgomp/error.c
> @@ -77,7 +77,7 @@ void
> gomp_vfatal (const char *fmt, va_list list)
> {
> gomp_verror (fmt, list);
> - exit (EXIT_FAILURE);
> + abort ();
> }
>
> void
I don't like this, abort has quite different user visible behavior
from exit, e.g. the former often dumps core.
I believe in most places libgomp handles this by releasing locks before
calling gomp_{,v}fatal:
gomp_mutex_unlock (®ister_lock);
gomp_fatal ("Out of memory allocating %lu bytes", (unsigned long) size);
gomp_mutex_unlock (&devicep->lock);
gomp_fatal ("Copying of %s object [%p..%p) to %s object [%p..%p) failed",
src, srcaddr, srcaddr + size, dst, dstaddr, dstaddr + size);
etc.
I could live with a gomp_fatal/gomp_vfatal alternative that would
use _exit/_Exit (but not sure if it is supported on all targets where
libgomp is) for uses where releasing locks is for whatever reason
not an option.
Jakub
next prev parent reply other threads:[~2022-10-19 13:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 17:04 Andrew Stubbs
2022-10-19 13:27 ` Jakub Jelinek [this message]
2022-10-19 16:08 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0/7WLIcxi0c1Mth@tucnak \
--to=jakub@redhat.com \
--cc=ams@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).