From: Jakub Jelinek <jakub@redhat.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libsanitizer: Avoid implicit function declaration in configure test
Date: Tue, 18 Oct 2022 14:52:54 +0200 [thread overview]
Message-ID: <Y06hpjQJ1a4T3V3v@tucnak> (raw)
In-Reply-To: <87r0z5jws2.fsf@oldenburg.str.redhat.com>
On Tue, Oct 18, 2022 at 11:39:25AM +0200, Florian Weimer via Gcc-patches wrote:
> libsanitizer/
>
> * configure.ac (check for necessary platform features):
I'd use (sanitizer_supported) or (SANITIZER_SUPPORTED) above instead,
that is what is what is being determined by the test.
> Include <unistd.h> for syscall prototype.
> * configure: Regenerate.
Otherwise LGTM, thanks.
> --- a/libsanitizer/configure.ac
> +++ b/libsanitizer/configure.ac
> @@ -161,7 +161,8 @@ case "$target" in
> *-*-linux*)
> # Some old Linux distributions miss required syscalls.
> sanitizer_supported=no
> - AC_TRY_COMPILE([#include <sys/syscall.h>],[
> + AC_TRY_COMPILE([#include <sys/syscall.h>
> +#include <unistd.h>],[
> syscall (__NR_gettid);
> syscall (__NR_futex);
> syscall (__NR_exit_group);
>
> base-commit: acdb24166d13d87c374e578d2ad5d58249171930
Jakub
prev parent reply other threads:[~2022-10-18 12:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 9:39 Florian Weimer
2022-10-18 12:52 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y06hpjQJ1a4T3V3v@tucnak \
--to=jakub@redhat.com \
--cc=fweimer@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).