public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [committed] Fix comment typos
@ 2022-10-07  7:11 Jakub Jelinek
  2022-10-07 11:21 ` Jonathan Wakely
  0 siblings, 1 reply; 5+ messages in thread
From: Jakub Jelinek @ 2022-10-07  7:11 UTC (permalink / raw)
  To: gcc-patches

Hi!

When looking at tree-inline.cc I've noticed a comment typo and grepped
for similar typos elsewhere.

Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk
as obvious.

2022-10-07  Jakub Jelinek  <jakub@redhat.com>

	* ipa-prop.h (ipa_constant_data): Fix comment typo.
	* value-range.cc (irange::irange_contains_p): Likewise.
	* value-relation.cc (dom_oracle::set_one_relation): Likewise.
	* gimple-predicate-analysis.cc (predicate::simplify_4): Likewise.
	* tree-inline.cc (remap_ssa_name): Likewise.

--- gcc/ipa-prop.h.jj	2022-05-25 11:07:29.516188277 +0200
+++ gcc/ipa-prop.h	2022-10-06 16:12:52.157055672 +0200
@@ -78,7 +78,7 @@ struct ipa_cst_ref_desc;
 /* Structure holding data required to describe a constant jump function.  */
 struct GTY(()) ipa_constant_data
 {
-  /* THe value of the constant.  */
+  /* The value of the constant.  */
   tree value;
   /* Pointer to the structure that describes the reference.  */
   struct ipa_cst_ref_desc GTY((skip)) *rdesc;
--- gcc/value-range.cc.jj	2022-10-06 08:55:02.668291942 +0200
+++ gcc/value-range.cc	2022-10-06 16:12:17.161531334 +0200
@@ -2508,7 +2508,7 @@ irange::irange_contains_p (const irange
       // Otherwise, check if this's pair occurs before R's.
       if (wi::lt_p (wi::to_wide (u), wi::to_wide (rl), sign))
 	{
-	  // THere's still at leats one pair of R left.
+	  // There's still at leats one pair of R left.
 	  if (++i >= num_pairs ())
 	    return false;
 	  l = m_base[i * 2];
--- gcc/value-relation.cc.jj	2022-09-30 14:12:44.654058401 +0200
+++ gcc/value-relation.cc	2022-10-06 16:12:34.527295298 +0200
@@ -955,7 +955,7 @@ dom_oracle::set_one_relation (basic_bloc
 	  ptr->dump (dump_file);
 	}
       // Check into whether we can simply replace the relation rather than
-      // intersecting it.  THis may help with some optimistic iterative
+      // intersecting it.  This may help with some optimistic iterative
       // updating algorithms.
       bool new_rel = ptr->intersect (vr);
       if (dump_file && (dump_flags & TDF_DETAILS))
--- gcc/gimple-predicate-analysis.cc.jj	2022-09-09 12:27:28.259668112 +0200
+++ gcc/gimple-predicate-analysis.cc	2022-10-06 16:11:36.676081607 +0200
@@ -1369,7 +1369,7 @@ predicate::simplify_3 ()
 /* Implement rule 4 for the OR predicate PREDS:
 
    2) ((x AND y) != 0) OR (x != 0 AND y != 0) is equivalent to
-       (x != 0 ANd y != 0).   */
+       (x != 0 AND y != 0).   */
 
 bool
 predicate::simplify_4 ()
--- gcc/tree-inline.cc.jj	2022-05-30 14:07:02.191304381 +0200
+++ gcc/tree-inline.cc	2022-10-06 16:11:57.455799164 +0200
@@ -171,7 +171,7 @@ remap_ssa_name (tree name, copy_body_dat
   n = id->decl_map->get (name);
   if (n)
     {
-      /* WHen we perform edge redirection as part of CFG copy, IPA-SRA can
+      /* When we perform edge redirection as part of CFG copy, IPA-SRA can
 	 remove an unused LHS from a call statement.  Such LHS can however
 	 still appear in debug statements, but their value is lost in this
 	 function and we do not want to map them.  */

	Jakub


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [committed] Fix comment typos
  2022-10-07  7:11 [committed] Fix comment typos Jakub Jelinek
@ 2022-10-07 11:21 ` Jonathan Wakely
  0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Wakely @ 2022-10-07 11:21 UTC (permalink / raw)
  To: Jakub Jelinek; +Cc: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]

On 07/10/22 09:11 +0200, Jakub Jelinek wrote:
>--- gcc/ipa-prop.h.jj	2022-05-25 11:07:29.516188277 +0200
>+++ gcc/ipa-prop.h	2022-10-06 16:12:52.157055672 +0200
>@@ -78,7 +78,7 @@ struct ipa_cst_ref_desc;
> /* Structure holding data required to describe a constant jump function.  */
> struct GTY(()) ipa_constant_data
> {
>-  /* THe value of the constant.  */
>+  /* The value of the constant.  */
>   tree value;
>   /* Pointer to the structure that describes the reference.  */
>   struct ipa_cst_ref_desc GTY((skip)) *rdesc;
>--- gcc/value-range.cc.jj	2022-10-06 08:55:02.668291942 +0200
>+++ gcc/value-range.cc	2022-10-06 16:12:17.161531334 +0200
>@@ -2508,7 +2508,7 @@ irange::irange_contains_p (const irange
>       // Otherwise, check if this's pair occurs before R's.
>       if (wi::lt_p (wi::to_wide (u), wi::to_wide (rl), sign))
> 	{
>-	  // THere's still at leats one pair of R left.
>+	  // There's still at leats one pair of R left.

There's still at least one typo here ;-)

I'll push the attached as obvious.



[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 771 bytes --]

commit 5c868666ce2014acf64d817dc31031deab1ecc93
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Fri Oct 7 12:20:36 2022

    gcc: Fix comment typo
    
    gcc/ChangeLog:
    
            * value-range.cc (irange::irange_contains_p): Fix comment typo.

diff --git a/gcc/value-range.cc b/gcc/value-range.cc
index 16105f87678..a14f9bc4394 100644
--- a/gcc/value-range.cc
+++ b/gcc/value-range.cc
@@ -2509,7 +2509,7 @@ irange::irange_contains_p (const irange &r) const
       // Otherwise, check if this's pair occurs before R's.
       if (wi::lt_p (wi::to_wide (u), wi::to_wide (rl), sign))
 	{
-	  // There's still at leats one pair of R left.
+	  // There's still at least one pair of R left.
 	  if (++i >= num_pairs ())
 	    return false;
 	  l = m_base[i * 2];

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [committed] Fix comment typos
  2024-01-17 10:23 Jakub Jelinek
@ 2024-01-19 21:14 ` rep.dot.nop
  0 siblings, 0 replies; 5+ messages in thread
From: rep.dot.nop @ 2024-01-19 21:14 UTC (permalink / raw)
  To: Jakub Jelinek, gcc-patches

Hi

Just another commentary typo..

On 17 January 2024 11:23:01 CET, Jakub Jelinek <jakub@redhat.com> wrote:

>--- gcc/gengtype.cc.jj	2024-01-03 11:51:23.314845233 +0100
>+++ gcc/gengtype.cc	2024-01-16 18:56:57.383009291 +0100
>@@ -4718,8 +4718,8 @@ write_roots (pair_p variables, bool emit
> }
> 
> /* Prints not-as-ugly version of a typename of T to OF.  Trades the uniquness
>-   guaranteee for somewhat increased readability.  If name conflicts do happen,

s/uniquness/uniqueness/g

thanks

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [committed] Fix comment typos
@ 2024-01-17 10:23 Jakub Jelinek
  2024-01-19 21:14 ` rep.dot.nop
  0 siblings, 1 reply; 5+ messages in thread
From: Jakub Jelinek @ 2024-01-17 10:23 UTC (permalink / raw)
  To: gcc-patches

Hi!

When looking at PR113410, I found a comment typo and just searched for
the same typo elsewhere and found some typos in the comments which had
that typo as well.

Bootstrapped/regtested on x86_64-linux and i686-linux, committed to
trunk as obvious.

2024-01-17  Jakub Jelinek  <jakub@redhat.com>

	* tree-into-ssa.cc (pass_build_ssa::gate): Fix comment typo,
	funcions -> functions, and use were instead of was.
	* gengtype.cc (dump_typekind): Fix comment typos, funcion -> function
	and guaranteee -> guarantee.
	* attribs.h (struct attr_access): Fix comment typo funcion -> function.

--- gcc/tree-into-ssa.cc.jj	2024-01-03 11:51:34.128695146 +0100
+++ gcc/tree-into-ssa.cc	2024-01-16 18:57:38.136438943 +0100
@@ -2499,7 +2499,7 @@ public:
   /* opt_pass methods: */
   bool gate (function *fun) final override
     {
-      /* Do nothing for funcions that was produced already in SSA form.  */
+      /* Do nothing for functions that were produced already in SSA form.  */
       return !(fun->curr_properties & PROP_ssa);
     }
 
--- gcc/gengtype.cc.jj	2024-01-03 11:51:23.314845233 +0100
+++ gcc/gengtype.cc	2024-01-16 18:56:57.383009291 +0100
@@ -4718,8 +4718,8 @@ write_roots (pair_p variables, bool emit
 }
 
 /* Prints not-as-ugly version of a typename of T to OF.  Trades the uniquness
-   guaranteee for somewhat increased readability.  If name conflicts do happen,
-   this funcion will have to be adjusted to be more like
+   guarantee for somewhat increased readability.  If name conflicts do happen,
+   this function will have to be adjusted to be more like
    output_mangled_typename.  */
 
 #define INDENT 2
--- gcc/attribs.h.jj	2024-01-03 11:51:24.200832936 +0100
+++ gcc/attribs.h	2024-01-16 19:08:27.507350364 +0100
@@ -324,7 +324,7 @@ struct attr_access
      in TREE_VALUE and their positions in the argument list (stored
      in TREE_PURPOSE).  Each expression may be a PARM_DECL or some
      other DECL (for ordinary variables), or an EXPR for other
-     expressions (e.g., funcion calls).  */
+     expressions (e.g., function calls).  */
   tree size;
 
   /* The zero-based position of each of the formal function arguments.

	Jakub


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [committed] Fix comment typos.
@ 2007-11-14 13:10 Rask Ingemann Lambertsen
  0 siblings, 0 replies; 5+ messages in thread
From: Rask Ingemann Lambertsen @ 2007-11-14 13:10 UTC (permalink / raw)
  To: gcc-patches

   I committed these typo fixes as revision 130176.

Index: gcc/ChangeLog
===================================================================
--- gcc/ChangeLog	(revision 130174)
+++ gcc/ChangeLog	(working copy)
@@ -1,3 +1,9 @@
+2007-11-14  Rask Ingemann Lambertsen  <rask@sygehus.dk>
+
+	* global.c (rest_of_handle_global_alloc): Fix comment typos.
+	* config/sh/sh.c (sh_rtx_costs): Likewise.
+	* ChangeLog: Likewise.
+
 2007-11-13  Sebastian Pop  <sebastian.pop@amd.com>
 
 	* tree-chrec.h (build_polynomial_chrec): RHS of a chrec
@@ -14667,18 +14673,18 @@
 	and adjust recursive call accordingly.
 	(prescan_insns_for_dce): Update call to delete_insn_p.
 
-2007-06-30  Rask Ingemann Lambertsen <rask@sygehus.dk>
+2007-06-30  Rask Ingemann Lambertsen  <rask@sygehus.dk>
 
 	* combine.c (combine_validate_cost): New parameter NEWOTHERPAT.
 	(try_combine): Move potential calls to undo_all() so they happen
 	before we commit to using the combined insns.
 
-2006-06-30  Jan Hubicka  <jh@suse.cz>
+2007-06-30  Jan Hubicka  <jh@suse.cz>
 
 	* loop-unroll.c (unroll_loop_runtime_iterations): Unshare newly emit
 	code.
 
-2006-06-30  Thomas Neumann  <tneumann@users.sourceforge.net>
+2007-06-30  Thomas Neumann  <tneumann@users.sourceforge.net>
 
 	* ipa.c (cgraph_postorder): Cast according to the coding conventions.
 	(cgraph_remove_unreachable_nodes): Likewise.
Index: gcc/global.c
===================================================================
--- gcc/global.c	(revision 130174)
+++ gcc/global.c	(working copy)
@@ -1771,7 +1771,7 @@ rest_of_handle_global_alloc (void)
   reload_completed = !failure;
 
   /* The world has changed so much that at this point we might as well
-     just rescan everything.  Not that df_rescan_all_insns is not
+     just rescan everything.  Note that df_rescan_all_insns is not
      going to help here because it does not touch the artificial uses
      and defs.  */
   df_finish_pass (true);
Index: gcc/config/sh/sh.c
===================================================================
--- gcc/config/sh/sh.c	(revision 130174)
+++ gcc/config/sh/sh.c	(working copy)
@@ -2408,7 +2408,7 @@ sh_rtx_costs (rtx x, int code, int outer
 	       && CONST_OK_FOR_K08 (INTVAL (x)))
         *total = 1;
       /* prepare_cmp_insn will force costly constants int registers before
-	 the cbrach[sd]i4 patterns can see them, so preserve potentially
+	 the cbranch[sd]i4 patterns can see them, so preserve potentially
 	 interesting ones not covered by I08 above.  */
       else if (outer_code == COMPARE
 	       && ((unsigned HOST_WIDE_INT) INTVAL (x)
@@ -2435,7 +2435,7 @@ sh_rtx_costs (rtx x, int code, int outer
       if (TARGET_SHMEDIA)
         *total = COSTS_N_INSNS (4);
       /* prepare_cmp_insn will force costly constants int registers before
-	 the cbrachdi4 pattern can see them, so preserve potentially
+	 the cbranchdi4 pattern can see them, so preserve potentially
 	 interesting ones.  */
       else if (outer_code == COMPARE && GET_MODE (x) == DImode)
         *total = 1;

-- 
Rask Ingemann Lambertsen
Danish law requires addresses in e-mail to be logged and stored for a year

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-01-19 21:14 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-07  7:11 [committed] Fix comment typos Jakub Jelinek
2022-10-07 11:21 ` Jonathan Wakely
  -- strict thread matches above, loose matches on Subject: below --
2024-01-17 10:23 Jakub Jelinek
2024-01-19 21:14 ` rep.dot.nop
2007-11-14 13:10 Rask Ingemann Lambertsen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).