From: Jakub Jelinek <jakub@redhat.com>
To: Aldy Hernandez <aldyh@redhat.com>
Cc: GCC patches <gcc-patches@gcc.gnu.org>,
Andrew MacLeod <amacleod@redhat.com>
Subject: Re: [PATCH] Check rvc_normal in real_isdenormal.
Date: Fri, 14 Oct 2022 16:37:58 +0200 [thread overview]
Message-ID: <Y0l0RoVyZHMeCo2r@tucnak> (raw)
In-Reply-To: <20221014143047.672008-1-aldyh@redhat.com>
On Fri, Oct 14, 2022 at 04:30:47PM +0200, Aldy Hernandez wrote:
> [Jakub, thanks for pointing this out. OK?]
>
> [-Inf, -Inf] is being flushed to [-Inf, -0.0] because real_isdenormal
> is being overly pessimistic. It is missing a check for rvc_normal.
> This doesn't cause problems in real.cc because all uses of
> real_isdenormal are already on the rvc_normal path. The uses in
> value-range.cc however, are not.
>
> This patch adds a check for rvc_normal.
>
> gcc/ChangeLog:
>
> * real.h (real_isdenormal): Check rvc_normal.
> * value-range.cc (range_tests_floats): New test.
LGTM.
Jakub
prev parent reply other threads:[~2022-10-14 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 14:30 Aldy Hernandez
2022-10-14 14:37 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0l0RoVyZHMeCo2r@tucnak \
--to=jakub@redhat.com \
--cc=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).