From: Jakub Jelinek <jakub@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: [PATCH] testsuite: Fix up c2x-enum-1.c for 32-bit arches [PR107311]
Date: Wed, 19 Oct 2022 18:22:59 +0200 [thread overview]
Message-ID: <Y1AkY7V2xil5Wpub@tucnak> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2210191456300.7558@digraph.polyomino.org.uk>
Hi!
On Wed, Oct 19, 2022 at 02:57:59PM +0000, Joseph Myers wrote:
> I think the type checked for e5a should be conditional on __LONG_MAX__ >
> __INT_MAX__; everything else there should be OK regardless.
So like this?
Tested on x86_64-linux with -m32 and -m64, ok for trunk?
2022-10-19 Jakub Jelinek <jakub@redhat.com>
PR c/107311
* gcc.dg/c2x-enum-1.c (enum e5): Expect e5a type inside of
enum to be int rather than long if long isn't wider than int.
--- gcc/testsuite/gcc.dg/c2x-enum-1.c.jj 2022-10-19 01:15:21.025186231 +0200
+++ gcc/testsuite/gcc.dg/c2x-enum-1.c 2022-10-19 18:19:45.215215713 +0200
@@ -82,7 +82,12 @@ enum e5 { e5a = __LONG_MAX__,
e5b, e5c, e5d = ((typeof (e5b)) -1) < 0,
e5e = (unsigned long) -1,
e5f, e5g = ((typeof (e5e)) -1) > 0,
- TYPE_CHECK (e5a, long), TYPE_CHECK (e5e, unsigned long) };
+#if __LONG_MAX__ > __INT_MAX__
+ TYPE_CHECK (e5a, long),
+#else
+ TYPE_CHECK (e5a, int),
+#endif
+ TYPE_CHECK (e5e, unsigned long) };
extern enum e5 e5v;
extern typeof (e5a) e5v;
extern typeof (e5b) e5v;
Jakub
next prev parent reply other threads:[~2022-10-19 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 14:08 [committed] c: C2x enums wider than int [PR36113] Joseph Myers
2022-10-18 23:55 ` Jakub Jelinek
2022-10-19 14:57 ` Joseph Myers
2022-10-19 16:22 ` Jakub Jelinek [this message]
2022-10-19 16:28 ` [PATCH] testsuite: Fix up c2x-enum-1.c for 32-bit arches [PR107311] Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1AkY7V2xil5Wpub@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).