From: Joseph Myers <joseph@codesourcery.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [committed] c: C2x enums wider than int [PR36113]
Date: Wed, 19 Oct 2022 14:57:59 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2210191456300.7558@digraph.polyomino.org.uk> (raw)
In-Reply-To: <Y089Dk5CirY1WlZJ@tucnak>
On Wed, 19 Oct 2022, Jakub Jelinek wrote:
> > +/* Likewise, for overflow from long to long long. */
> > +#if __LONG_LONG_MAX__ > __LONG_MAX__
> > +enum e5 { e5a = __LONG_MAX__,
> > + e5b, e5c, e5d = ((typeof (e5b)) -1) < 0,
> > + e5e = (unsigned long) -1,
> > + e5f, e5g = ((typeof (e5e)) -1) > 0,
> > + TYPE_CHECK (e5a, long), TYPE_CHECK (e5e, unsigned long) };
>
> This fails on x86_64-linux with -m32 and I assume most other 32-bit
> targets, it works with
> TYPE_CHECK (e5a, int), TYPE_CHECK (e5e, unsigned long) };
> Haven't checked in detail, but if int and long have the same bitsize,
> doesn't __LONG_MAX__ fit into int and so this new handling of large
> enumerators doesn't apply?
> Can we just change that unconditionally, or shall it be conditional
> on #if __LONG_MAX__ > __INT_MAX__ (then use long, otherwise int)?
I think the type checked for e5a should be conditional on __LONG_MAX__ >
__INT_MAX__; everything else there should be OK regardless.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2022-10-19 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 14:08 Joseph Myers
2022-10-18 23:55 ` Jakub Jelinek
2022-10-19 14:57 ` Joseph Myers [this message]
2022-10-19 16:22 ` [PATCH] testsuite: Fix up c2x-enum-1.c for 32-bit arches [PR107311] Jakub Jelinek
2022-10-19 16:28 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2210191456300.7558@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).