From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Andrew Stubbs <ams@codesourcery.com>,
"Vollweiler, Marcel" <marcel@codesourcery.com>
Subject: Re: [Patch] libgomp: Add offload_device_gcn check, add requires-4a.c test
Date: Thu, 20 Oct 2022 12:46:41 +0200 [thread overview]
Message-ID: <Y1EnEQHQydi9jeEo@tucnak> (raw)
In-Reply-To: <ebcb6977-c445-264e-ce06-d56beb4bbcc0@codesourcery.com>
On Wed, Oct 12, 2022 at 04:05:32PM +0200, Tobias Burnus wrote:
> include/ChangeLog:
>
> * gomp-constants.h (GOMP_DEVICE_HSA): Comment (unused).
Comment out unused define.
or so, please.
> libgomp/ChangeLog:
>
> * testsuite/lib/libgomp.exp (check_effective_target_offload_device_gcn):
> New.
> * testsuite/libgomp.c-c++-common/on_device_arch.h (device_arch_gcn,
> on_device_arch_gcn): New.
> * testsuite/libgomp.c-c++-common/requires-4a.c: New test; copied from
> requires-4.c but using heap-allocated memory.
Otherwise LGTM.
Jakub
prev parent reply other threads:[~2022-10-20 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 14:05 Tobias Burnus
2022-10-17 7:36 ` *ping* / " Tobias Burnus
2022-10-20 10:46 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1EnEQHQydi9jeEo@tucnak \
--to=jakub@redhat.com \
--cc=ams@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=marcel@codesourcery.com \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).