* [PATCH 05/12] ipa-sra: Dump edge summaries also for non-candidates
@ 2022-11-12 1:46 Martin Jambor
2022-11-16 13:48 ` Jan Hubicka
0 siblings, 1 reply; 2+ messages in thread
From: Martin Jambor @ 2022-11-12 1:46 UTC (permalink / raw)
To: GCC Patches; +Cc: Jan Hubicka, Jan Hubicka
Hi,
this should have been part of r12-578-g717d278af93a4a. Call edge
summaries provide information required for IPA-SRA transformations in
the callees but are generated when analyzing callers and thus also
callers which are not IPA-SRA candidates themselves. Therefore we
analyze them but don't dump them, which makes the dumops quite
incomplete. This patch fixes that.
Bootstrapped and tested on x86_64-linux. OK for master?
Thanks,
Martin
gcc/ChangeLog:
2021-12-14 Martin Jambor <mjambor@suse.cz>
* ipa-sra.c (ipa_sra_dump_all_summaries): Dump edge summaries even
for non-candidates.
---
gcc/ipa-sra.cc | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/gcc/ipa-sra.cc b/gcc/ipa-sra.cc
index 959e8829777..0f137e810fe 100644
--- a/gcc/ipa-sra.cc
+++ b/gcc/ipa-sra.cc
@@ -2806,13 +2806,10 @@ ipa_sra_dump_all_summaries (FILE *f)
if (!ifs)
fprintf (f, " Function does not have any associated IPA-SRA "
"summary\n");
+ else if (!ifs->m_candidate)
+ fprintf (f, " Not a candidate function\n");
else
{
- if (!ifs->m_candidate)
- {
- fprintf (f, " Not a candidate function\n");
- continue;
- }
if (ifs->m_returns_value)
fprintf (f, " Returns value\n");
if (vec_safe_is_empty (ifs->m_parameters))
--
2.38.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 05/12] ipa-sra: Dump edge summaries also for non-candidates
2022-11-12 1:46 [PATCH 05/12] ipa-sra: Dump edge summaries also for non-candidates Martin Jambor
@ 2022-11-16 13:48 ` Jan Hubicka
0 siblings, 0 replies; 2+ messages in thread
From: Jan Hubicka @ 2022-11-16 13:48 UTC (permalink / raw)
To: Martin Jambor; +Cc: GCC Patches
> Hi,
>
> this should have been part of r12-578-g717d278af93a4a. Call edge
> summaries provide information required for IPA-SRA transformations in
> the callees but are generated when analyzing callers and thus also
> callers which are not IPA-SRA candidates themselves. Therefore we
> analyze them but don't dump them, which makes the dumops quite
> incomplete. This patch fixes that.
>
> Bootstrapped and tested on x86_64-linux. OK for master?
>
> Thanks,
>
> Martin
>
>
> gcc/ChangeLog:
>
> 2021-12-14 Martin Jambor <mjambor@suse.cz>
>
> * ipa-sra.c (ipa_sra_dump_all_summaries): Dump edge summaries even
> for non-candidates.
OK,
thanks!
Honza
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-16 13:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-12 1:46 [PATCH 05/12] ipa-sra: Dump edge summaries also for non-candidates Martin Jambor
2022-11-16 13:48 ` Jan Hubicka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).