From: Jakub Jelinek <jakub@redhat.com>
To: Jason Merrill <jason@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH RFA(configure)] c++: provide strchrnul on targets without it [PR107781]
Date: Tue, 22 Nov 2022 12:12:23 +0100 [thread overview]
Message-ID: <Y3yul3XQBF+kGxeF@tucnak> (raw)
In-Reply-To: <Y3yLNN3qofx5fcSl@tucnak>
On Tue, Nov 22, 2022 at 09:41:24AM +0100, Jakub Jelinek via Gcc-patches wrote:
> On Mon, Nov 21, 2022 at 06:31:47PM -0500, Jason Merrill via Gcc-patches wrote:
> > Tested x86_64-pc-linux-gnu, and also manually changing the HAVE_DECL_STRCHRNUL
> > flag. OK for trunk?
> >
> > -- 8< --
> >
> > The Contracts implementation uses strchrnul, which is a glibc extension, so
> > bootstrap broke on non-glibc targets. I considered unconditionally using a
> > local definition, but I guess we might as well use the libc version if it
> > exists.
> >
> > PR c++/107781
> >
> > gcc/cp/ChangeLog:
> >
> > * contracts.cc (strchrnul): Define if needed.
> >
> > gcc/ChangeLog:
> >
> > * configure.ac: Check for strchrnul.
> > * config.in, configure: Regenerate.
>
> Normally we'd add such a local definition to libiberty, shouldn't we do it
> in this case too?
Or use strcspn as Jonathan posted in the PR, at least glibc will handle
it as strchrnul (start, reject[0]) - start early in the strcspn
implementation.
Jakub
next prev parent reply other threads:[~2022-11-22 11:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 23:31 Jason Merrill
2022-11-22 8:41 ` Jakub Jelinek
2022-11-22 11:12 ` Jakub Jelinek [this message]
2022-11-22 14:29 ` [pushed] c++: don't use strchrnul [PR107781] Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3yul3XQBF+kGxeF@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).