From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch] libgomp: Add no-target-region rev offload test + fix plugin-nvptx
Date: Fri, 25 Nov 2022 12:25:37 +0100 [thread overview]
Message-ID: <Y4CmMZVCVww3Sysb@tucnak> (raw)
In-Reply-To: <64661eda-7f5f-da60-894f-00f90f1def04@codesourcery.com>
On Thu, Nov 24, 2022 at 06:48:01PM +0100, Tobias Burnus wrote:
> libgomp: Add no-target-region rev offload test + fix plugin-nvptx
>
> OpenMP permits that a 'target device(ancestor:1)' is called without being
> enclosed in a target region - using the current device (i.e. the host) in
> that case. This commit adds a testcase for this.
>
> In case of nvptx, the missing on-device 'GOMP_target_ext' call causes that
> it and also the associated on-device GOMP_REV_OFFLOAD_VAR variable are not
> linked in from nvptx's libgomp.a. Thus, handle the failing cuModuleGetGlobal
> gracefully by disabling reverse offload and assuming that the failure is fine.
>
> libgomp/ChangeLog:
>
> * plugin/plugin-nvptx.c (GOMP_OFFLOAD_load_image): Use unsigned int
> for 'i' to match 'fn_entries'; regard absent GOMP_REV_OFFLOAD_VAR
> as valid and the code having no reverse-offload code.
> * testsuite/libgomp.c-c++-common/reverse-offload-2.c: New test.
Ok, thanks.
Jakub
prev parent reply other threads:[~2022-11-25 11:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 17:48 Tobias Burnus
2022-11-25 11:25 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4CmMZVCVww3Sysb@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).