Re: [Patch] libgomp: Handle OpenMP's reverse offloads

[Jakub Jelinek <jakub@redhat.com>]

On Sat, Dec 10, 2022 at 09:11:24AM +0100, Tobias Burnus wrote:
> It is used as 'typedef struct reverse_splay_tree_node_s *reverse_splay_tree_node;' in
> 
> struct target_mem_desc {
> ....
>   reverse_splay_tree_node rev_array;
> }
> 
> but also as
> 
> struct gomp_device_descr
> {
>   ...
>   struct reverse_splay_tree_s mem_map_rev;
> }
> 
> The latter is
> 
> struct reverse_splay_tree_key_s {
>   /* Address of the device object.  */
>   uint64_t dev;
>   splay_tree_key k;
> };
> 
> which in turn needs 'splay_tree_key'.
> 
> Thus, I could either commit it as is – or turn the latter also
> into a pointer and malloc it. Currently, it is accessed as
> mem_map.k.root = NULL for init and later through the splay-tree
> functions indirectly.
> 
> Thoughts?
> 
> Unless there are further comments, I will later commit it as is.

Ok; just wanted to save compile time by not including too much for all the
other files...

	Jakub