From: Tobias Burnus <tobias@codesourcery.com>
To: gcc-patches <gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>
Subject: Re: [Patch] libgomp.texi: Reverse-offload updates (was: [Patch] libgomp: Handle OpenMP's reverse offloads)
Date: Sat, 10 Dec 2022 09:18:26 +0100 [thread overview]
Message-ID: <a96724a2-3a82-2713-526a-a9069d373029@codesourcery.com> (raw)
In-Reply-To: <a3383e0b-29d1-622b-3278-f10aa173fa62@codesourcery.com>
[-- Attachment #1: Type: text/plain, Size: 617 bytes --]
Now that the reverse-offload patch is (nearly) in:
On 07.12.22 09:08, Tobias Burnus wrote:
> On 06.12.22 08:45, Tobias Burnus wrote:
>> * As follow-up, libgomp.texi must be updated
Slight update to that uncommitted patch: I extended the nvptx entry to
state that only one reverse-offload region runs at a given time.
OK?
Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
[-- Attachment #2: nvptx-rev-offload.diff --]
[-- Type: text/x-patch, Size: 3438 bytes --]
libgomp.texi: Reverse-offload updates
libgomp/
* libgomp.texi (5.0 Impl. Status): Update 'requires' and 'ancestor'.
(GCN): Add item about 'omp requires'.
(nvptx): Likewise; add item about reverse offload.
libgomp/libgomp.texi | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/libgomp/libgomp.texi b/libgomp/libgomp.texi
index b6c1ed714ce..f95e82fc8aa 100644
--- a/libgomp/libgomp.texi
+++ b/libgomp/libgomp.texi
@@ -192,8 +192,8 @@ The OpenMP 4.5 specification is fully supported.
env variable @tab Y @tab
@item Nested-parallel changes to @emph{max-active-levels-var} ICV @tab Y @tab
@item @code{requires} directive @tab P
- @tab complete but no non-host devices provides @code{unified_address},
- @code{unified_shared_memory} or @code{reverse_offload}
+ @tab complete but no non-host devices provides @code{unified_address} or
+ @code{unified_shared_memory}
@item @code{teams} construct outside an enclosing target region @tab Y @tab
@item Non-rectangular loop nests @tab Y @tab
@item @code{!=} as relational-op in canonical loop form for C/C++ @tab Y @tab
@@ -228,7 +228,7 @@ The OpenMP 4.5 specification is fully supported.
@item @code{allocate} clause @tab P @tab Initial support
@item @code{use_device_addr} clause on @code{target data} @tab Y @tab
@item @code{ancestor} modifier on @code{device} clause
- @tab Y @tab See comment for @code{requires}
+ @tab Y @tab Host fallback with GCN devices
@item Implicit declare target directive @tab Y @tab
@item Discontiguous array section with @code{target update} construct
@tab N @tab
@@ -288,7 +288,7 @@ The OpenMP 4.5 specification is fully supported.
@code{append_args} @tab N @tab
@item @code{dispatch} construct @tab N @tab
@item device-specific ICV settings with environment variables @tab Y @tab
-@item @code{assume} directive @tab Y @tab
+@item @code{assume} and @code{assumes} directives @tab Y @tab
@item @code{nothing} directive @tab Y @tab
@item @code{error} directive @tab Y @tab
@item @code{masked} construct @tab Y @tab
@@ -4456,6 +4456,9 @@ The implementation remark:
@item I/O within OpenMP target regions and OpenACC parallel/kernels is supported
using the C library @code{printf} functions and the Fortran
@code{print}/@code{write} statements.
+@item OpenMP code that has a requires directive with @code{unified_address},
+ @code{unified_shared_memory} or @code{reverse_offload} will remove
+ any GCN device from the list of available devices (``host fallback'').
@end itemize
@@ -4507,6 +4510,15 @@ The implementation remark:
@item Compilation OpenMP code that contains @code{requires reverse_offload}
requires at least @code{-march=sm_35}, compiling for @code{-march=sm_30}
is not supported.
+@item For code containing reverse offload (i.e. @code{target} regions with
+ @code{device(ancestor:1)}), there is a slight performance penality
+ for @emph{all} target regions, consisting mostly of shutdown delay
+ Per device, reverse offload regions are processed serial such that
+ the next reverse offload region is only executed after the previous
+ one returns.
+@item OpenMP code that has a requires directive with @code{unified_address}
+ or @code{unified_shared_memory} will remove any nvptx device from the
+ list of available devices (``host fallback'').
@end itemize
next prev parent reply other threads:[~2022-12-10 8:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 7:45 [Patch] libgomp: Handle OpenMP's reverse offloads Tobias Burnus
2022-12-07 8:08 ` [Patch] libgomp.texi: Reverse-offload updates (was: [Patch] libgomp: Handle OpenMP's reverse offloads) Tobias Burnus
2022-12-10 8:18 ` Tobias Burnus [this message]
2023-01-31 12:21 ` Jakub Jelinek
2022-12-09 14:44 ` [Patch] libgomp: Handle OpenMP's reverse offloads Jakub Jelinek
2022-12-10 8:11 ` Tobias Burnus
2022-12-10 8:28 ` Jakub Jelinek
2022-12-15 17:34 ` Thomas Schwinge
2022-12-15 17:49 ` Jakub Jelinek
2022-12-15 19:42 ` Tobias Burnus
2022-12-15 20:13 ` Tobias Burnus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a96724a2-3a82-2713-526a-a9069d373029@codesourcery.com \
--to=tobias@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).