From: Jakub Jelinek <jakub@redhat.com>
To: Eric Biggers <ebiggers@google.com>, Jonathan Wakely <jwakely@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] options: fix cl_target_option_print_diff() with strings
Date: Tue, 24 Jan 2023 11:58:13 +0100 [thread overview]
Message-ID: <Y8+5xd29w182PnKV@tucnak> (raw)
In-Reply-To: <Y8+09/igI64AySFq@redhat.com>
On Tue, Jan 24, 2023 at 10:37:43AM +0000, Jonathan Wakely wrote:
> Changing CC to gcc-patches instead of gcc-bugs ...
The fix is obvious, so I've committed it. Thanks.
> On 24/01/23 04:14 +0000, Eric Biggers wrote:
> > Fix an obvious copy-and-paste error where ptr1 was used instead of ptr2.
> > This bug caused the dump file produced by -fdump-ipa-inline-details to
> > not correctly show the difference in target options when a function
> > could not be inlined due to a target option mismatch.
Though, if you have a small reproducer, it would be nice to include it
in GCC testsuite.
> >
> > gcc/ChangeLog:
> >
> > * optc-save-gen.awk: Fix copy-and-paste error.
> >
> > Fixes: b54ecc769f59 ("re PR bootstrap/90543 (Build failure on MINGW for gcc-9.1.0)")
The above line doesn't belong here, instead PR bootstrap/90543 should be
above the * optc-save-gen.awk ... line.
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > ---
> > gcc/optc-save-gen.awk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gcc/optc-save-gen.awk b/gcc/optc-save-gen.awk
> > index e91adf7f132..d2cb53c477f 100644
> > --- a/gcc/optc-save-gen.awk
> > +++ b/gcc/optc-save-gen.awk
> > @@ -1013,7 +1013,7 @@ for (i = 0; i < n_target_string; i++) {
> > print " indent, \"\",";
> > print " \"" name "\",";
> > print " ptr1->x_" name " ? ptr1->x_" name " : \"(null)\",";
> > - print " ptr2->x_" name " ? ptr1->x_" name " : \"(null)\");";
> > + print " ptr2->x_" name " ? ptr2->x_" name " : \"(null)\");";
> > print "";
> > }
> >
> > --
> > 2.39.1.405.gd4c25cc71f-goog
> >
Jakub
prev parent reply other threads:[~2023-01-24 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230124041453.2595798-1-ebiggers@google.com>
2023-01-24 10:37 ` Jonathan Wakely
2023-01-24 10:58 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8+5xd29w182PnKV@tucnak \
--to=jakub@redhat.com \
--cc=ebiggers@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).